Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package names #6421

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

edmundhung
Copy link
Member

What this PR solves / how to test

It looks like one test in ./tools start failing because of the new package @cloudflare/workers-shared introduced in #6370 recently. This PR should fix the issue.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@edmundhung edmundhung requested a review from a team as a code owner August 5, 2024 18:19
Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: a5701d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edmundhung edmundhung force-pushed the edmundhung/update-package-names branch from ec70a14 to a5701d5 Compare August 5, 2024 18:21
Copy link
Contributor

github-actions bot commented Aug 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-wrangler-6421

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6421/npm-package-wrangler-6421

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-wrangler-6421 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-create-cloudflare-6421 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-cloudflare-kv-asset-handler-6421
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-miniflare-6421
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-cloudflare-pages-shared-6421
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10253990942/npm-package-cloudflare-vitest-pool-workers-6421

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit 83cf4c4 into main Aug 5, 2024
18 checks passed
@edmundhung edmundhung deleted the edmundhung/update-package-names branch August 5, 2024 19:09
emily-shen pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants