-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the included file in tests for the hello world template #6410
Conversation
🦋 Changeset detectedLatest commit: 8c8fe8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-wrangler-6410 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6410/npm-package-wrangler-6410 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-wrangler-6410 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-create-cloudflare-6410 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-kv-asset-handler-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-miniflare-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-pages-shared-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-vitest-pool-workers-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workers-editor-shared-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workers-shared-6410 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workflows-shared-6410 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this @stof!
@stof can you please add a changeset and resolve merge conflicts? thanks! |
@lrapoport-cf done. |
hi @stof this PR is ready to merge, Can you please rebase on latest |
Congratulations @stof, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3x5ew1625360cl14vxxyut5 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Create a new project using typescript and then run
tsc -p test
to run typechecking on the tests.Author has addressed the following