Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the included file in tests for the hello world template #6410

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

stof
Copy link
Contributor

@stof stof commented Aug 2, 2024

What this PR solves / how to test

Create a new project using typescript and then run tsc -p test to run typechecking on the tests.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: tsconfig.json change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: tsconfig.json change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: it only fixes a mistake in the C3 template

@stof stof requested a review from a team as a code owner August 2, 2024 16:54
Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: 8c8fe8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-wrangler-6410

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6410/npm-package-wrangler-6410

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-wrangler-6410 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-create-cloudflare-6410 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-kv-asset-handler-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-miniflare-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-pages-shared-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-vitest-pool-workers-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workers-editor-shared-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workers-shared-6410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895793449/npm-package-cloudflare-workflows-shared-6410

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this @stof!

@lrapoport-cf
Copy link
Contributor

@stof can you please add a changeset and resolve merge conflicts? thanks!

@stof
Copy link
Contributor Author

stof commented Nov 18, 2024

@lrapoport-cf done.

@CarmenPopoviciu
Copy link
Contributor

hi @stof

this PR is ready to merge, Can you please rebase on latest main so I can go ahead with the merge 🙏 ?

@CarmenPopoviciu CarmenPopoviciu added the skip-pr-description-validation Skip validation of the required PR description format label Nov 25, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit c808590 into cloudflare:main Nov 25, 2024
32 of 39 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 25, 2024
Copy link

holopin-bot bot commented Nov 25, 2024

Congratulations @stof, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3x5ew1625360cl14vxxyut5

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@stof stof deleted the patch-1 branch November 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants