Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect parse for env binding #581

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix incorrect parse for env binding #581

merged 1 commit into from
Mar 16, 2022

Conversation

mnixry
Copy link
Contributor

@mnixry mnixry commented Mar 12, 2022

For example

npx wrangler pages dev public/ -b "AAA=foo=bar; foo2=bar2" # actually i want to pass a cookie

It will be parsed to

{
  AAA: 'foo' // all remaining arguments are lost!
}

But it should be parsed to

{
  AAA: 'foo=bar; foo2=bar2' 
}

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2022

⚠️ No Changeset found

Latest commit: 00e46e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin
Copy link
Contributor

This looks reasonable to me, but we should get @GregBrimble to make the final decision...

@petebacondarwin petebacondarwin added the pages Relating to Pages label Mar 12, 2022
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1973232754/npm-package-wrangler-581

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/581/npm-package-wrangler-581

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/1973232754/npm-package-wrangler-581 dev path/to/script.js

@GregBrimble GregBrimble merged commit 0f66675 into cloudflare:main Mar 16, 2022
@GregBrimble
Copy link
Member

Thank you, @mnixry, for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants