Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Apr 7, 2024

What this PR solves / how to test

This PR generates a JSON schema for Wrangler, as well as updating C3 templates to add a schema property to generated config file. Once merged and released, we should follow up by merging SchemaStore/schemastore#3692.

Fixes #5057, fixes #5055, fixes #3166, DEVX-1242

Author has addressed the following

@penalosa penalosa requested a review from a team as a code owner April 7, 2024 16:18
@penalosa penalosa requested a review from a team April 7, 2024 16:18
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2024

🦋 Changeset detected

Latest commit: bd1ef9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
create-cloudflare Minor
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-wrangler-5550

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5550/npm-package-wrangler-5550

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-wrangler-5550 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-create-cloudflare-5550 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-kv-asset-handler-5550
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-miniflare-5550
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-pages-shared-5550
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-vitest-pool-workers-5550

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240404.0
workerd 1.20240404.0 1.20240404.0
workerd --version 1.20240404.0 2024-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa requested a review from CarmenPopoviciu April 9, 2024 13:05
@CarmenPopoviciu
Copy link
Contributor

thank you for working on this @penalosa <3

@penalosa penalosa force-pushed the penalosa/wrangler-config-schema branch from a428cc1 to 21bc8e0 Compare April 9, 2024 14:44
@penalosa penalosa force-pushed the penalosa/wrangler-config-schema branch from 21bc8e0 to bd1ef9d Compare April 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants