Skip to content

C3: Improve cron/scheduled template docs#5547

Merged
petebacondarwin merged 2 commits intocloudflare:mainfrom
connorads:cron-c3-template-docs
May 15, 2024
Merged

C3: Improve cron/scheduled template docs#5547
petebacondarwin merged 2 commits intocloudflare:mainfrom
connorads:cron-c3-template-docs

Conversation

@connorads
Copy link
Copy Markdown
Contributor

@connorads connorads commented Apr 7, 2024

What this PR solves / how to test

First time starting to do a scheduled worker locally so I use the template: get all obscure warnings and error messages as per #4720. Really not intuitive to the uninitiated. This doesn't solve that issue completely but should hopefully help.

https://developers.cloudflare.com/workers/runtime-apis/handlers/scheduled/

Fixes #4720, #4560

image

Author has addressed the following

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2024

🦋 Changeset detected

Latest commit: bc11264

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connorads connorads marked this pull request as ready for review April 7, 2024 14:38
@connorads connorads requested a review from a team as a code owner April 7, 2024 14:38
@connorads connorads requested a review from a team April 7, 2024 14:38
@connorads connorads changed the title Improve cron C3 template docs C3: Improve cron/scheduled template docs Apr 8, 2024
Copy link
Copy Markdown
Contributor

@jculvey jculvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-wrangler-5547

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5547/npm-package-wrangler-5547

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-wrangler-5547 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-create-cloudflare-5547 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-cloudflare-kv-asset-handler-5547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-miniflare-5547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-cloudflare-pages-shared-5547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097994504/npm-package-cloudflare-vitest-pool-workers-5547

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.56.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (2789f26) to head (96e04ce).
Report is 119 commits behind head on main.

❗ Current head 96e04ce differs from pull request most recent head bc11264. Consider uploading reports for the commit bc11264 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5547      +/-   ##
==========================================
- Coverage   72.44%   72.42%   -0.03%     
==========================================
  Files         331      331              
  Lines       17298    17298              
  Branches     4422     4422              
==========================================
- Hits        12532    12528       -4     
- Misses       4766     4770       +4     

see 2 files with indirect coverage changes

@petebacondarwin petebacondarwin self-assigned this Apr 21, 2024
@petebacondarwin petebacondarwin force-pushed the cron-c3-template-docs branch 2 times, most recently from 6e9ad49 to 541f5b6 Compare April 24, 2024 12:05
@petebacondarwin petebacondarwin force-pushed the cron-c3-template-docs branch from 541f5b6 to 9b044df Compare May 15, 2024 13:59
@petebacondarwin petebacondarwin force-pushed the cron-c3-template-docs branch from 9b044df to bc11264 Compare May 15, 2024 14:58
@petebacondarwin petebacondarwin merged commit e6ecf8c into cloudflare:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Improve cron template docs

4 participants