Skip to content

Fix fixture types after adding entrypoints#5499

Merged
penalosa merged 2 commits intomainfrom
fix-busted-entrypoint-types
Apr 4, 2024
Merged

Fix fixture types after adding entrypoints#5499
penalosa merged 2 commits intomainfrom
fix-busted-entrypoint-types

Conversation

@GregBrimble
Copy link
Copy Markdown
Contributor

What this PR solves / how to test

Looks like somehow we ended up with failing types after #5215. This adds the one line we're missing in a fixture test.

Author has addressed the following

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: ebddea5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-wrangler-5499

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5499/npm-package-wrangler-5499

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-wrangler-5499 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-create-cloudflare-5499 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-kv-asset-handler-5499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-miniflare-5499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-pages-shared-5499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-vitest-pool-workers-5499

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.45.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240329.1
workerd 1.20240403.0 1.20240403.0
workerd --version 1.20240403.0 2024-04-03

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.18%. Comparing base (cd03d1d) to head (ebddea5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5499      +/-   ##
==========================================
+ Coverage   72.11%   72.18%   +0.07%     
==========================================
  Files         331      331              
  Lines       17175    17175              
  Branches     4386     4386              
==========================================
+ Hits        12385    12398      +13     
+ Misses       4790     4777      -13     

see 7 files with indirect coverage changes

* Bump workerd@1.20240403.0

* Remove no-longer-necessary rpc compatibility flags
@GregBrimble GregBrimble requested a review from a team as a code owner April 4, 2024 08:16
@penalosa penalosa merged commit 6c3be5b into main Apr 4, 2024
@penalosa penalosa deleted the fix-busted-entrypoint-types branch April 4, 2024 10:25
@workers-devprod workers-devprod mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants