Use new Discord server url#5482
Conversation
🦋 Changeset detectedLatest commit: a0665f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-wrangler-5482You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5482/npm-package-wrangler-5482Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-wrangler-5482 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-create-cloudflare-5482 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-kv-asset-handler-5482npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-miniflare-5482npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-pages-shared-5482npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-vitest-pool-workers-5482Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
==========================================
+ Coverage 72.44% 72.51% +0.06%
==========================================
Files 331 331
Lines 17298 17298
Branches 4422 4422
==========================================
+ Hits 12532 12544 +12
+ Misses 4766 4754 -12
|
07bd8d9 to
40c4819
Compare
|
Okay, apparently the hyperdrive warnings was removed |
WalshyDev
left a comment
There was a problem hiding this comment.
Approved from community side.
petebacondarwin
left a comment
There was a problem hiding this comment.
I'd like to double check that there are no e2e tests that will break from this...
Might be worth just pushing up a draft PR that is pushed to the cloudflare fork.
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
bc2ff8c to
a0665f2
Compare
What this PR solves / how to test
Hi 👋,
I was originally reproducing and fixing a completely unrelated bug in c3, but noticed the old url in the summary after creating a project. Since the new URL is preferred, I thought I'd PR it, and a quick search found another 20 or so matches.
The only remaining instances of the old .gg/cloudflaredev one are in changelog entries, which I didn't want to modify.
The changeset for this is a patch to every touched package, not sure if this is worth releasing kv-asset-handler for. Also since Hyperdrive is now GA (🎉), the banner might go away so if this would cause merge conflicts, happy to undo any conflicting ones (also Constellation).
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following