Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Mar 20, 2024

What this PR solves / how to test

In --no-bundle mode watch the entire module root for changes, rather than just the entrypoint file. Additionally, watch the requirements.txt file for Python workers.

Fixes EW-8223

Author has addressed the following

@penalosa penalosa requested a review from a team as a code owner March 20, 2024 11:09
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 93f592b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the e2e Run wrangler + vite-plugin e2e tests on a PR label Mar 20, 2024
@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (00820be) to head (93f592b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5310      +/-   ##
==========================================
+ Coverage   72.16%   72.22%   +0.05%     
==========================================
  Files         317      317              
  Lines       16372    16372              
  Branches     4169     4169              
==========================================
+ Hits        11815    11824       +9     
+ Misses       4557     4548       -9     

see 6 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5310/npm-package-wrangler-5310

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-create-cloudflare-5310 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-kv-asset-handler-5310
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-miniflare-5310
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-pages-shared-5310
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-vitest-pool-workers-5310

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge :)

@penalosa penalosa force-pushed the penalosa/watch-requirements branch from 6602432 to 79c9cc2 Compare March 22, 2024 15:27
@penalosa penalosa merged commit 528c011 into main Mar 25, 2024
@penalosa penalosa deleted the penalosa/watch-requirements branch March 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants