feat: a better tsconfig.json
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f02e87a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1881606446/npm-package-wrangler-512You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/512/npm-package-wrangler-512Or you can use npx https://prerelease-registry.developers.workers.dev/runs/1881606446/npm-package-wrangler-512 dev path/to/script.js |
threepointone
commented
Feb 22, 2022
| fs.readFileSync("./tsconfig.json", "utf-8") | ||
| ); | ||
| // tsconfig.json isn't necessarily valid json, so let's use eval to parse it | ||
| const tsconfigJson = eval( |
There was a problem hiding this comment.
We can use:
import {parseConfigFileTextToJson} from "typescript";
...
parseConfigFileTextToJson("./tsconfig.json", fs.readFileSync("./tsconfig.json", "utf-8"));There was a problem hiding this comment.
I considered it... heck why not. changing.
petebacondarwin
approved these changes
Feb 22, 2022
| fs.readFileSync("./tsconfig.json", "utf-8") | ||
| ); | ||
| // tsconfig.json isn't necessarily valid json, so let's use eval to parse it | ||
| const tsconfigJson = eval( |
There was a problem hiding this comment.
We can use:
import {parseConfigFileTextToJson} from "typescript";
...
parseConfigFileTextToJson("./tsconfig.json", fs.readFileSync("./tsconfig.json", "utf-8"));
threepointone
force-pushed
the
tweak-tsconfig
branch
from
f70ae66
to
210f88e
Compare
This makes a better `tsconfig.json` when using `wrangler init`. Of note, it takes the default `tsconfig.json` generated by `tsc --init`, and adds our modifications.
threepointone
force-pushed
the
tweak-tsconfig
branch
from
210f88e
to
f02e87a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a better
tsconfig.jsonwhen usingwrangler init. Of note, it takes the defaulttsconfig.jsongenerated bytsc --init, and adds our modifications.