Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] fix: don't suggest reporting UserErrors to GitHub #5030

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Feb 16, 2024

Fixes #3867.

What this PR solves / how to test:

I tried to reproduce #3867 by updating my .wrangler/config/default.toml with an access token expiry in the past, and an invalid refresh token, but wrangler whaomi just opened a browser and prompted me to login. It's possible this specific issue was fixed in another PR. 🤔 Either way, given the recent work to split out UserErrors, of which the Not logged in. error seen here is one, it seemed like a good idea to hide the bug reporting message in these cases.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: changing error messaging

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested review from a team as code owners February 16, 2024 11:42
Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 4fcf159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-wrangler-5030

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5030/npm-package-wrangler-5030

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-wrangler-5030 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-create-cloudflare-5030 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-cloudflare-kv-asset-handler-5030
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-miniflare-5030
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-cloudflare-pages-shared-5030

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.2
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a751489) 70.42% compared to head (4fcf159) 70.46%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5030      +/-   ##
==========================================
+ Coverage   70.42%   70.46%   +0.03%     
==========================================
  Files         297      297              
  Lines       15425    15424       -1     
  Branches     3952     3951       -1     
==========================================
+ Hits        10863    10868       +5     
+ Misses       4562     4556       -6     
Files Coverage Δ
packages/wrangler/src/index.ts 90.00% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@mrbbot mrbbot merged commit 55ea072 into main Feb 16, 2024
17 checks passed
@mrbbot mrbbot deleted the bcoll/dont-suggest-user-error-issue branch February 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: whoami results in an fatal error when the session is expired
2 participants