-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: bump vite and vitest to latest versions #4899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-wrangler-4899You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4899/npm-package-wrangler-4899Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-wrangler-4899 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-create-cloudflare-4899 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-cloudflare-kv-asset-handler-4899npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-miniflare-4899npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-cloudflare-pages-shared-4899Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4899 +/- ##
=======================================
Coverage 70.45% 70.46%
=======================================
Files 295 295
Lines 15411 15411
Branches 3948 3948
=======================================
+ Hits 10858 10859 +1
+ Misses 4553 4552 -1 |
3b96efa to
fb19e67
Compare
fb19e67 to
e07d711
Compare
|
I believe the only blocker for this is now fixing the e2e tests: #4907 |
77e034d to
d7d83e1
Compare
d7d83e1 to
b934dd0
Compare
b934dd0 to
b5f28f4
Compare
Closes #4798
What this PR solves / how to test:
In attempting to update Vitest in a dependabot PR, we noticed that there were a mix of versions of Vitest and that there would be some tricky parts to bumping the version. Moreover updating to the latest Vitest requires updating Vite as a transitive dependency, and we have a direct dependency on this too.
This work here brings everything to the latest versions and aligns it across the repository.
The update to Vitest had some breaking changes to a number of tests and configuration files have been fixed accordingly.
Author has addressed the following: