Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Feb 1, 2024

Closes #4798

What this PR solves / how to test:

In attempting to update Vitest in a dependabot PR, we noticed that there were a mix of versions of Vitest and that there would be some tricky parts to bumping the version. Moreover updating to the latest Vitest requires updating Vite as a transitive dependency, and we have a direct dependency on this too.

This work here brings everything to the latest versions and aligns it across the repository.

The update to Vitest had some breaking changes to a number of tests and configuration files have been fixed accordingly.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: it is an internal chore.
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: it is an internal chore.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: b5f28f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin changed the title chore: bump vite and vitest to latest versions WIP chore: bump vite and vitest to latest versions Feb 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-wrangler-4899

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4899/npm-package-wrangler-4899

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-wrangler-4899 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-create-cloudflare-4899 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-cloudflare-kv-asset-handler-4899
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-miniflare-4899
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7869621710/npm-package-cloudflare-pages-shared-4899

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.1
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7ccc85) 70.45% compared to head (b5f28f4) 70.46%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4899   +/-   ##
=======================================
  Coverage   70.45%   70.46%           
=======================================
  Files         295      295           
  Lines       15411    15411           
  Branches     3948     3948           
=======================================
+ Hits        10858    10859    +1     
+ Misses       4553     4552    -1     

see 4 files with indirect coverage changes

@petebacondarwin petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Feb 2, 2024
Base automatically changed from c3-update-vitest-meta-to-task to main February 2, 2024 12:47
@petebacondarwin petebacondarwin self-assigned this Feb 3, 2024
@petebacondarwin petebacondarwin added the blocked Blocked on other work label Feb 3, 2024
@petebacondarwin
Copy link
Contributor Author

I believe the only blocker for this is now fixing the e2e tests: #4907

@petebacondarwin petebacondarwin force-pushed the update-vite-and-vitest branch 3 times, most recently from 77e034d to d7d83e1 Compare February 8, 2024 15:42
@petebacondarwin petebacondarwin removed the blocked Blocked on other work label Feb 8, 2024
@petebacondarwin petebacondarwin marked this pull request as ready for review February 12, 2024 10:05
@petebacondarwin petebacondarwin requested a review from a team as a code owner February 12, 2024 10:05
@petebacondarwin petebacondarwin requested a review from a team February 12, 2024 10:05
@petebacondarwin petebacondarwin requested a review from a team as a code owner February 12, 2024 10:05
@petebacondarwin petebacondarwin changed the title WIP chore: bump vite and vitest to latest versions chore: bump vite and vitest to latest versions Feb 12, 2024
@petebacondarwin petebacondarwin merged commit 7ad8ddd into main Feb 12, 2024
@petebacondarwin petebacondarwin deleted the update-vite-and-vitest branch February 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants