-
Notifications
You must be signed in to change notification settings - Fork 1.1k
expose no-op caches in getBindingsProxy
#4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7fac49f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0fe6dce to
c3847bd
Compare
c6894b2 to
8b45a67
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-wrangler-4847You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4847/npm-package-wrangler-4847Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-wrangler-4847 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-create-cloudflare-4847 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-miniflare-4847npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-cloudflare-pages-shared-4847Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
d565895 to
2ddb78e
Compare
caches in getBindingsProxy
caches in getBindingsProxycaches in getBindingsProxy
2ddb78e to
21aab5d
Compare
21aab5d to
75b4184
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4847 +/- ##
==========================================
- Coverage 70.70% 70.69% -0.01%
==========================================
Files 291 292 +1
Lines 15164 15178 +14
Branches 3859 3859
==========================================
+ Hits 10721 10730 +9
- Misses 4443 4448 +5
|
|
@mrbbot I've used classes as you've suggested 🙂 (thanks for the suggestions! 😄) Please have another look 🙂 |
|
Does |
Yes (and thanks for reminding me! ❤️): https://developers.cloudflare.com/workers/wrangler/api/#getbindingsproxy I will update them later if that's ok by you 🙏 |
mrbbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! ✅ Thanks for making those changes. 😃
Usage example: https://github.com/dario-piotrowicz/getBindingsProxy-poc-demo/blob/main/demo/index.ts
Docs issue (to be followed up on later): cloudflare/cloudflare-docs#12783