Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 27, 2024

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2024

🦋 Changeset detected

Latest commit: 7fac49f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-wrangler-4847

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4847/npm-package-wrangler-4847

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-wrangler-4847 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-create-cloudflare-4847 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-miniflare-4847
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7710895300/npm-package-cloudflare-pages-shared-4847

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.4
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz force-pushed the caches-getBindingsProxy branch 2 times, most recently from d565895 to 2ddb78e Compare January 29, 2024 22:41
@dario-piotrowicz dario-piotrowicz changed the title expose caches in getBindingsProxy expose __no-op__caches in getBindingsProxy Jan 29, 2024
@dario-piotrowicz dario-piotrowicz changed the title expose __no-op__caches in getBindingsProxy expose no-op caches in getBindingsProxy Jan 29, 2024
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review January 29, 2024 23:03
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner January 29, 2024 23:03
@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fbd2a4c) 70.70% compared to head (7fac49f) 70.69%.
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4847      +/-   ##
==========================================
- Coverage   70.70%   70.69%   -0.01%     
==========================================
  Files         291      292       +1     
  Lines       15164    15178      +14     
  Branches     3859     3859              
==========================================
+ Hits        10721    10730       +9     
- Misses       4443     4448       +5     
Files Coverage Δ
...es/wrangler/src/api/integrations/bindings/index.ts 22.85% <100.00%> (+2.26%) ⬆️
...s/wrangler/src/api/integrations/bindings/caches.ts 8.33% <8.33%> (ø)

... and 7 files with indirect coverage changes

@dario-piotrowicz
Copy link
Member Author

@mrbbot I've used classes as you've suggested 🙂 (thanks for the suggestions! 😄)

Please have another look 🙂

@mrbbot
Copy link
Contributor

mrbbot commented Jan 30, 2024

Does getBindingsProxy() have docs that will need updating too?

@dario-piotrowicz
Copy link
Member Author

Does getBindingsProxy() have docs that will need updating too?

Yes (and thanks for reminding me! ❤️): https://developers.cloudflare.com/workers/wrangler/api/#getbindingsproxy

I will update them later if that's ok by you 🙏

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! ✅ Thanks for making those changes. 😃

@dario-piotrowicz dario-piotrowicz merged commit 6968e11 into main Jan 30, 2024
@dario-piotrowicz dario-piotrowicz deleted the caches-getBindingsProxy branch January 30, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants