Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler@2] fix: pin workerd to 1.20230404.0 #4609

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 15, 2023

What this PR solves / how to test:

This PR aims to fix Wrangler 2's tests by pinning the version of workerd depended on by Miniflare 3.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: trying to get existing tests to pass
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: not user facing changes

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner December 15, 2023 11:00
Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 71b3d90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrbbot mrbbot changed the title fix: pin workerd to 1.20230404.0 [wrangler@2] fix: pin workerd to 1.20230404.0 Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2-maintenance@49a4696). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             v2-maintenance    #4609   +/-   ##
=================================================
  Coverage                  ?   74.53%           
=================================================
  Files                     ?      179           
  Lines                     ?    10940           
  Branches                  ?     2911           
=================================================
  Hits                      ?     8154           
  Misses                    ?     2786           
  Partials                  ?        0           

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no-bundle-import's tests pass 🎉

@mrbbot mrbbot merged commit c228c91 into v2-maintenance Dec 15, 2023
@mrbbot mrbbot deleted the bcoll/v2-pin-workerd branch December 15, 2023 15:30
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants