Skip to content

Conversation

@jculvey
Copy link
Contributor

@jculvey jculvey commented Nov 21, 2023

What this PR solves / how to test:

This PR improves the wrangler init --from-dash workflow by:

  • Displaying a label for the pre-existing type (currently says type: undefined)
  • Defaulting the project name to the name of the pre-existing script

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • [ x ] Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team November 21, 2023 17:56
@jculvey jculvey requested a review from a team as a code owner November 21, 2023 17:56
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 5e15c5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6974018210/npm-package-wrangler-4481

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6974018210/npm-package-wrangler-4481

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6974018210/npm-package-wrangler-4481 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6974018210/npm-package-miniflare-4481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6974018210/npm-package-cloudflare-pages-shared-4481

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.17.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jculvey jculvey force-pushed the jculvey/init-from-dash-fixes branch from 2f30701 to 37a2fdf Compare November 22, 2023 15:15
@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #4481 (5e15c5a) into main (5f54f72) will increase coverage by 0.17%.
Report is 18 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
+ Coverage   75.27%   75.45%   +0.17%     
==========================================
  Files         226      240      +14     
  Lines       12568    12851     +283     
  Branches     3260     3309      +49     
==========================================
+ Hits         9461     9697     +236     
- Misses       3107     3154      +47     

see 29 files with indirect coverage changes

Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
@jculvey jculvey merged commit 18a4dd9 into main Nov 28, 2023
@jculvey jculvey deleted the jculvey/init-from-dash-fixes branch November 28, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants