-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Redirect workers.new to the playground #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-wrangler-4039You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6319557633/npm-package-wrangler-4039Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-wrangler-4039 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-cloudflare-pages-shared-4039Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
admah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@penalosa @admah @lrapoport-cf — @tsmith512 and I just realized that links to |
|
@irvinebroque This was intentional so as not to break old links. We can definitely change that behaviour though? |
|
I see. Right now none of the examples on Stackblitz work, and in order to
get them to work, have to continue to use Wrangler V2.
My only opinion is that we should direct people to something that works.
…On Thu, Oct 12, 2023 at 6:41 AM Somhairle MacLeòid ***@***.***> wrote:
@irvinebroque <https://github.com/irvinebroque> This was intentional so
as not to break old links. We can definitely change that behaviour though?
—
Reply to this email directly, view it on GitHub
<#4039 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJKHWC35QHR457KDYL3H7LX67XQXANCNFSM6AAAAAA5IPTNGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@irvinebroque do you know where these links are coming from? Stackblitz doesn't work with wrangler v3+ and may not anytime soon. The other issue here is that our playground doesn't currently support TS, so redirecting users using this URL (workers.new/typescript) is also not the best option IMO. |
|
@admah they're defined within the |
|
@penalosa I don't see any mention of |
|
to close the loop, is there any action requested here? |
Fixes # [insert GH or internal issue number(s)].
What this PR solves / how to test:
Redirect
workers.newto the new Workers PlaygroundAssociated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.