Skip to content

Conversation

@penalosa
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:
Redirect workers.new to the new Workers Playground

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@penalosa penalosa requested a review from a team as a code owner September 26, 2023 23:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: 31ab89c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-wrangler-4039

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6319557633/npm-package-wrangler-4039

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-wrangler-4039 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6319557633/npm-package-cloudflare-pages-shared-4039

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@penalosa penalosa merged commit 913c00b into main Sep 28, 2023
@penalosa penalosa deleted the penalosa/playground-entrypoint branch September 28, 2023 12:56
@irvinebroque
Copy link
Contributor

@penalosa @admah @lrapoport-cf — @tsmith512 and I just realized that links to workers.new/typescript are still redirecting to Stackblitz, not to the Playground.

@penalosa
Copy link
Contributor Author

@irvinebroque This was intentional so as not to break old links. We can definitely change that behaviour though?

@irvinebroque
Copy link
Contributor

irvinebroque commented Oct 12, 2023 via email

@admah
Copy link
Contributor

admah commented Oct 12, 2023

@irvinebroque do you know where these links are coming from? Stackblitz doesn't work with wrangler v3+ and may not anytime soon. The other issue here is that our playground doesn't currently support TS, so redirecting users using this URL (workers.new/typescript) is also not the best option IMO.

@penalosa
Copy link
Contributor Author

@admah they're defined within the workers.new package, I think. I wonder where they're actually used though—do we reference them on the docs or anything like that?

@admah
Copy link
Contributor

admah commented Oct 12, 2023

@penalosa I don't see any mention of /typescript in the docs. It looks like all current docs links for workers.new are Stream related. Of note, traffic to /typescript is extremely limited. Maybe it's only internal use?

@tsmith512
Copy link
Contributor

Yeah, on further review, this seemed to be something only Stream had in DevDocs. Someone on Discord pointed out that one of them was broken, which I have fixed (ref #4157) but that's when I realized they're all like this. (cc @dcpena for our call coming up)

@lrapoport-cf
Copy link
Contributor

to close the loop, is there any action requested here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants