-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c3] fix c3 js scheduled template to have correct main file reference. #3916
Conversation
🦋 Changeset detectedLatest commit: 3699e55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-wrangler-3916 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6126639499/npm-package-wrangler-3916 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-wrangler-3916 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-cloudflare-pages-shared-3916 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
+ Coverage 75.10% 75.12% +0.02%
==========================================
Files 195 195
Lines 11487 11487
Branches 3036 3036
==========================================
+ Hits 8627 8630 +3
+ Misses 2860 2857 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@admah good to merge? |
@jculvey yes! Lost this one in the mix somewhere. Thanks! |
Fixes # [insert GH or internal issue number(s)].
#3913
What this PR solves / how to test:
Create a Scheduled Worker via C3, selecting NO to TypeScript. The
main
entry inwrangler.toml
should beindex.js
, and the project should be able to be deployed.Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.