Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c3] fix c3 js scheduled template to have correct main file reference. #3916

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

admah
Copy link
Contributor

@admah admah commented Sep 8, 2023

Fixes # [insert GH or internal issue number(s)].

#3913

What this PR solves / how to test:

Create a Scheduled Worker via C3, selecting NO to TypeScript. The main entry in wrangler.toml should be index.js, and the project should be able to be deployed.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@admah admah requested review from a team as code owners September 8, 2023 21:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

🦋 Changeset detected

Latest commit: 3699e55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-wrangler-3916

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6126639499/npm-package-wrangler-3916

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-wrangler-3916 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6126639499/npm-package-cloudflare-pages-shared-3916

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230904.0 3.20230904.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3916 (3699e55) into main (a986f19) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3916      +/-   ##
==========================================
+ Coverage   75.10%   75.12%   +0.02%     
==========================================
  Files         195      195              
  Lines       11487    11487              
  Branches     3036     3036              
==========================================
+ Hits         8627     8630       +3     
+ Misses       2860     2857       -3     

see 2 files with indirect coverage changes

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jculvey
Copy link
Contributor

jculvey commented Sep 28, 2023

@admah good to merge?

@admah admah merged commit 15d75e5 into main Sep 28, 2023
20 of 21 checks passed
@admah admah deleted the admah/fixc3scheduledtemplate branch September 28, 2023 19:48
@admah
Copy link
Contributor Author

admah commented Sep 28, 2023

@jculvey yes! Lost this one in the mix somewhere. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants