chore: add eslint-plugin-import
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds `eslint-plugin-import` to enforce ordering of imports, and configuration for the same in `package.json`. - I also run `npm run check:lint -- --fix` to apply the configured order in our whole codebase. - This also needs a setting in `.vscode/settings.json` to prevent spurious warnings inside vscode. You'll probably have to restart your IDE for this to take effect. (re: import-js/eslint-plugin-import#2377 (comment)) (I'd also like to enforce using `node:` prefixes for node builtin modules, but that can happen later. For now I manually added the prefixes wherever they were missing. It's not functionally any different, but imo it helps the visual grouping.)
🦋 Changeset detectedLatest commit: 47807ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
approved these changes
Feb 1, 2022
Merged
This was referenced Nov 23, 2023
This was referenced Dec 1, 2023
This was referenced Dec 9, 2023
This was referenced Feb 24, 2024
This was referenced Mar 4, 2024
This was referenced Mar 12, 2024
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-importto enforce ordering of imports, and configuration for the same inpackage.json.npm run check:lint -- --fixto apply the configured order in our whole codebase..vscode/settings.jsonto prevent spurious warnings inside vscode. You'll probably have to restart your IDE for this to take effect. (re:node:-prefixed modules not recognised asbuiltins import-js/eslint-plugin-import#2377 (comment))(I'd also like to enforce using
node:prefixes for node builtin modules, but that can happen later. For now I manually added the prefixes wherever they were missing. It's not functionally any different, but imo it helps the visual grouping.)