Fix Pages Functions path routing on Windows #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b2b0d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@petebacondarwin is working on an OS testing environment in the CI/CD (#329) which I think should go in before this. Then we can run the tests for this in the Windows environment. |
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Feb 1, 2022
Previously route paths were manipulated by file-system path utilities. On Windows this resulted in URLs that had backslashes, which are invalid for such URLs. Fixes cloudflare#51 Closes cloudflare#235 Closes cloudflare#330 Closes cloudflare#327
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Feb 1, 2022
Previously route paths were manipulated by file-system path utilities. On Windows this resulted in URLs that had backslashes, which are invalid for such URLs. Fixes cloudflare#51 Closes cloudflare#235 Closes cloudflare#330 Closes cloudflare#327
petebacondarwin
added a commit
that referenced
this pull request
Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue pointed out in #50 #51 where Pages Functions routes weren't properly routing due to Windows path separators being
\\instead of/. Tested this change on both Windows and Linux.Before:
functions\api\example.js->/apiexamplefunctions\api\[[path]].js->/api:path*After:
functions\api\example.js->/api/examplefunctions\api\[[path]].js->/api/:path*Edit: This might be good to go ahead and push out for Windows users. But I really like #331 as a more permanent fix to issues like this.