Support sourcemaps in DevTools #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38f5346 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4896386811/npm-package-wrangler-3140You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3140/npm-package-wrangler-3140Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4896386811/npm-package-wrangler-3140 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4896386811/npm-package-cloudflare-pages-shared-3140Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3140 +/- ##
==========================================
- Coverage 74.84% 74.63% -0.21%
==========================================
Files 179 179
Lines 10858 10899 +41
Branches 2880 2894 +14
==========================================
+ Hits 8127 8135 +8
- Misses 2731 2764 +33
|
mrbbot
reviewed
May 4, 2023
JacobMGEvans
reviewed
May 4, 2023
JacobMGEvans
reviewed
May 4, 2023
JacobMGEvans
reviewed
May 4, 2023
JacobMGEvans
reviewed
May 4, 2023
JacobMGEvans
approved these changes
May 4, 2023
mrbbot
approved these changes
May 4, 2023
penalosa
force-pushed
the
penalosa/support-sourcemaps-devtools
branch
from
3b5f611 to
0847c11
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
This PR enables support for sourcemaps in DevTools when using Wrangler.
It works by intercepting CDP messages from the DevTools frontend and responding in Wrangler. In particular:
Network.loadNetworkResponseis intercepted to provide DevTools with the right sourcemapDebugger.scriptParsedis intercepted afterworkerdin order to give schemes to URLs returned fromworkerd(which allows DevTools to treat modules as file paths with folders)Two additional DevTools patches are also included. 14 is a more-compliant ping implementation (thanks @mrbbot!) and 15 integrates with the Wrangler changes to enable sourcemaps, and enables some additional DevTools features to improve the experience of the Sources panel.
To test, run this branch build of Wrangler against a worker (
wrangler devorwrangler dev --experimental-local), and open up DevTools by pressing D. Replace the DevTools domain with the preview build of DevTools from this PR (currently https://ca712237.cloudflare-devtools.pages.dev/).Author has included the following, where applicable:
[ ] CI Testsworker-appwithwrangler devandwrangler dev --experimental-localno-bundle-importwithwrangler dev --no-bundleandwrangler dev --experimental-local --no-bundlesites-appwithwrangler devandwrangler dev --experimental-localReviewer has performed the following, where applicable: