refactor: implement a logging abstraction around console #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a `logger` service that should be used instead of `console`. The eslint configuration for the wrangler package `src` directory has been updated to error if someone tries to use `console` rather than `logger`. As well as providing a clean abstraction, this change also enables simpler testing of some Ink components. Specifically when an Ink component is used only to statically generate some output, we can now use the `renderString()` method to render the output to a string, which can be sent to the logger.
🦋 Changeset detectedLatest commit: 3920d43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Urgh! |
This was referenced Nov 23, 2023
This was referenced Dec 1, 2023
This was referenced Dec 9, 2023
This was referenced Jan 9, 2024
This was referenced Jan 17, 2024
This was referenced Jan 25, 2024
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a
loggerservice that should be used instead ofconsole.The eslint configuration for the wrangler package
srcdirectory has been updated to error if someone tries to useconsolerather thanlogger.As well as providing a clean abstraction, this change also enables simpler testing of some Ink components.
Specifically when an Ink component is used only to statically generate some output, we can now use the
renderString()method to render the output to a string, which can be sent to the logger.