Initial Ink removal

[penalosa]

This PR begins the process of removing Ink from places where it's not needed. Specifically it:

• Removes Ink from dialogs.tsx, which is the majority usage
• Renames files from .tsx to .ts where possible (in a separate commit to ease review)
• Removes Ink from the whoami command

[changeset-bot]

⚠️ No Changeset found

Latest commit: 02429fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[GregBrimble]

Haven't looked at anything else, but the Pages stuff is fine

[mrbbot]

Very nice! Glad we're making this change. 👍 I've added a few comments.

[mrbbot]

Awesome! One tiny comment, then LGTM! 🎉

[penalosa]

@rozenmd It would be great to get a review from a D1 perspective, if possible!

[penalosa]

@JacobMGEvans did you have any comments?

[JacobMGEvans]

@JacobMGEvans did you have any comments?

Nope.

[rozenmd]

Mind fixing the merge conflicts? I'll give the preview build a test drive tomorrow morning

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3847740985/npm-package-wrangler-2283

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2283/npm-package-wrangler-2283

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/3847740985/npm-package-wrangler-2283 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3847740985/npm-package-cloudflare-pages-shared-2283

[rozenmd]

Looks good from D1's side

[codecov]

Codecov Report

Merging #2283 (02429fe) into main (8986ccb) will increase coverage by 0.11%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
+ Coverage   72.13%   72.25%   +0.11%     
==========================================
  Files         156      156              
  Lines        9720     9687      -33     
  Branches     2546     2547       +1     
==========================================
- Hits         7012     6999      -13     
+ Misses       2708     2688      -20     

Impacted Files	Coverage Δ
packages/wrangler/src/bundle-reporter.ts	100.00% <ø> (ø)
packages/wrangler/src/d1/delete.ts	34.78% <ø> (ø)
packages/wrangler/src/d1/migrations/apply.tsx	34.52% <0.00%> (ø)
packages/wrangler/src/d1/migrations/index.ts	100.00% <ø> (ø)
packages/wrangler/src/dev-registry.ts	67.44% <ø> (ø)
...ges/wrangler/src/dev/get-local-persistence-path.ts	66.66% <ø> (ø)
packages/wrangler/src/index.ts	83.73% <ø> (ø)
packages/wrangler/src/pages/build.ts	85.48% <ø> (ø)
packages/wrangler/src/pages/deployment-tails.ts	83.69% <ø> (ø)
packages/wrangler/src/pages/dev.ts	19.02% <ø> (ø)
... and 19 more

[penalosa]

This should be ready for re-review! Of note, this fixes an issue with our confirm/select/prompt mocking—the mockSelect etc... functions didn't properly assert on their input (and whether they were called), and so most of init.test.ts has extraneous or erroneous calls to mockSelect/mockConfirm/mockPrompt.

[JacobMGEvans]

It is looking good, just a few questions and comments.

[mrbbot]

Nice! Added a few more comments...