Display a more helpful error when publishing to a route in use by another worker - #2023
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e1a0eda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3249591395/npm-package-wrangler-2023You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2023/npm-package-wrangler-2023Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3249591395/npm-package-wrangler-2023 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3249591395/npm-package-cloudflare-pages-shared-2023 |
Codecov Report
@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
- Coverage 72.77% 72.61% -0.17%
==========================================
Files 122 122
Lines 8368 8392 +24
Branches 2197 2203 +6
==========================================
+ Hits 6090 6094 +4
- Misses 2278 2298 +20
|
JacobMGEvans
approved these changes
Oct 13, 2022
penalosa
approved these changes
Oct 13, 2022
penalosa
left a comment
Contributor
There was a problem hiding this comment.
Couple comments, but looks good!
added 4 commits
October 14, 2022 06:25
caass
force-pushed
the
wrangler-publish-warn-custom-routes
branch
from
October 14, 2022 11:26
7962322 to
e1a0eda
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display a more helpful error when trying to publish to a route in use by another worker.
Previously, when trying to publish a worker to a route that was in use by another worker,
there would be a really unhelpful message about a failed API call. Now, there's a much
nicer message that tells you what worker is running on that route, and gives you a link
to the workers overview page so you can unassign it if you want.
Closes #1849