fix: prevent dev from infinitely restarting
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b702124 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
commented
Jan 2, 2022
| @@ -678,6 +680,8 @@ function useProxy({ | |||
| }, | |||
| }); | |||
|
|
|||
| console.log(`⬣ Listening at http://localhost:${port}`); | |||
There was a problem hiding this comment.
moved this message here because it just makes more sense here.
threepointone
force-pushed
the
fix-inifinite-restart
branch
from
08cb3d5
to
30982b8
Compare
In #164, we added `token` to `useWorker`'s `useEffect` array that detects when to start the server process. However, the effect itself sets `token`, so the build would inifinitely restart on every run. We could potentially fix this by using `useMemo` or something, but that's overkill for the reason we use `token` - to detect whether it's the first or subsequent time we've started the server, and what message to log to the terminal. So we introduce a ref `startedRef` to play that role, and mark it as true when we log the message the first time. This fixes the infinite loop. This bug shows how urgent it is to write tests for everything else. We'll get there.
threepointone
force-pushed
the
fix-inifinite-restart
branch
from
30982b8
to
5a5c6ee
Compare
petebacondarwin
approved these changes
Jan 3, 2022
|
|
||
| // This is the most reliable way to reliably detect whether | ||
| // something's "happened" in our system; We make a ref and | ||
| // mark it once we log our initial message. Refs are vars! |
There was a problem hiding this comment.
Thanks for this comment! Very helpful.
Co-authored-by: Pete Bacon Darwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #164, we added
tokentouseWorker'suseEffectarray that detects when to start the server process. However, the effect itself setstoken, so the build would inifinitely restart on every run.We could potentially fix this by using
useMemoor something, but that's overkill for the reason we usetoken- to detect whether it's the first or subsequent time we've started the server, and what message to log to the terminal. So we introduce a refstartedRefto play that role, and mark it as true when we log the message the first time. This fixes the infinite loop.This bug shows how urgent it is to write tests for everything else. We'll get there.