websocket support in dev
#150
Conversation
This resuscitates threepointone/nu-wrangler#19 via @Electroid. This probably needs tests, in a future PR. But it works well!
🦋 Changeset detectedLatest commit: ef64b87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great, thanks @threepointone and @Electroid! I'll look at working out how to incorporate this into |
.changeset/fuzzy-dancers-nail.md
Outdated
| "wrangler": patch | ||
| --- | ||
|
|
||
| Websocket support in `dev` |
There was a problem hiding this comment.
It would be great if we could get a bit more content into these changesets. 🙏
| headers[name] = value | ||
| .replaceAll(`https://${host}`, `http://localhost:${port}`) | ||
| .replaceAll(host, `localhost:${port}`); |
There was a problem hiding this comment.
Is it OK to mutate the headers object like this?
Would be safer to design this so that the onResponse(headers) returns a new headers object with the appropriate changes?
There was a problem hiding this comment.
It should be okay. But both onResponse and onRequest could be redesigned to require a return, instead of mutating.
There was a problem hiding this comment.
happy to revisit this in a future PR, might be a little more involved than just the return from the handler
This resuscitates https://github.com/threepointone/nu-wrangler/pull/19 via @Electroid. This probably needs tests, in a future PR. But it works well!