Upgrade miniflare to 2.0.0-rc.4 & pages dev quick wins
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enabled source map support - Log unhandled rejections instead of crashing - Add colours and prefixes to logs
🦋 Changeset detectedLatest commit: eddb2da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
requested changes
Dec 19, 2021
threepointone
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
Approving this, will wait for @GregBrimble to have a look before merging. Thanks @mrbbot!
|
Nvm, I'm going to just merge this and take for a spin, that's what alphas are for :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 This PR upgrades
miniflareto version2.0.0-rc.4: https://github.com/cloudflare/miniflare/releases/tag/v2.0.0-rc.4.This version includes support for logging unhandled rejections instead of crashing, which is automatically enabled when using the CLI, and also available as the
logUnhandledRejectionsoption. Whilst adding this, I thought I'd make a couple other tiny changes topages dev, which have been approved by @GregBrimble in conversation.sourcemap: trueto the esbuild options in@cloudflare/pages-functions-compilerbuildWorkerfunction)Logging unhandled rejections and source mapping are process wide, but since this is in the
pages devcommand handler, it shouldn't be a problem.