Delegate to local installs of wrangler when possible #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4f4c50a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2536345365/npm-package-wrangler-1270You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1270/npm-package-wrangler-1270Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2536345365/npm-package-wrangler-1270 dev path/to/script.js |
caass
force-pushed
the
delegate-to-local
branch
2 times, most recently
from
a749166 to
8cc6fbf
Compare
Users will frequently install `wrangler` globally to run commands like `wrangler init`, but we also recommend pinning a specific version of `wrangler` in a project's `package.json`. Now, when a user invokes a global install of `wrangler`, we'll check to see if they also have a local installation. If they do, we'll delegate to that version. This requires that we define a `main` (maybe `module` would work too?) field in `package.json` so that `require.resolve` can find `"wrangler"`, but it's something of an implementation detail.
caass
changed the title
petebacondarwin
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Approved with the following NITS:
- Add a warning message when we do actually delegate (inside
runDelegatedWrangler()?). - Move the node version check inside
runWrangler(). - Make
shouldDelegatea function and then we can call it like:
wranglerProcess = shouldDelegate() ? runDelegatedWrangler() : runWrangler();
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate to a local install of
wranglerif one exists.Users will frequently install
wranglerglobally to run commands likewrangler init, but we also recommend pinning a specific version ofwranglerin a project'spackage.json. Now, when a user invokes a global install ofwrangler, we'll check to see if they also have a local installation. If they do, we'll delegate to that version.Closes #955
Here's a recording of this in action, with a couple
console.logs indicating if a global or local installation is running: