Further wrangler init tests (and refactorings)
#124
Conversation
This commit uses jest spies to capture the output from `console` method calls to avoid having to hand code the capturing.
🦋 Changeset detectedLatest commit: 23e29e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -83,3 +83,9 @@ export async function prompt(text: string, type: "text" | "password" = "text") { | |||
| // ): Promise<{ label: string; value: string }>{ | |||
|
|
|||
| // } | |||
|
|
|||
| // Export as an object so that it is easier to mock for testing | |||
There was a problem hiding this comment.
This shouldn't be necessary, but I'll swing by next week and figure out mocking that'll let us keep the original exports. (Dropping this comment here to remind myself)
There was a problem hiding this comment.
I tried a number of different ways to achieve this by "mocking" the module. But it either didn't work or was really messy. I would be interested to see your approach.
| `compatibility_date = "${compatibilityDate}"` + "\n" | ||
| ); | ||
| console.log(`✨ Succesfully created wrangler.toml`); | ||
| // TODO: suggest next steps? |
There was a problem hiding this comment.
In the future, this might be a great place to suggest a list of "starters" and automatically make a src with contents. This may be a good replacement for the generate command.
| * then an error is thrown. | ||
| */ | ||
| function mockConfirm(...expectations: { text: string; result: boolean }[]) { | ||
| const mockImplementation = async (text: string) => { |
There was a problem hiding this comment.
dope mock, solves the input problem neatly.
|
Thanks for the quick review (after hours!!) |
petebacondarwin
force-pushed
the
kv-namespace-tests-2
branch
from
021a06c
to
23e29e7
Compare
As mentioned in #124 (comment), it's possible to use regular exports from a module, but still be able to mock their implementations in jest. This PR does so, and passes tests.
* export functions from dialogs.tsx, pass tests As mentioned in #124 (comment), it's possible to use regular exports from a module, but still be able to mock their implementations in jest. This PR does so, and passes tests.
See the individual commits...