-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure wrangler init works with older versions of git #1209
Conversation
Rather than using the recently added `--initial-branch` option, we now just renamed the initial branch using `git branch -m main`. Fixes cloudflare#1168
🦋 Changeset detectedLatest commit: 818c493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2466751189/npm-package-wrangler-1209 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1209/npm-package-wrangler-1209 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2466751189/npm-package-wrangler-1209 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to land this, just a question, fee free to take a call
await execa("git", ["init"], { | ||
cwd: creationDirectory, | ||
}); | ||
await execa("git", ["branch", "-m", "main"], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make 2 branches in every project? Do you think we should do this only as a fallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I don't know git lol, does this do a rename?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command simply renames the current branch (e.g. master) to main.
Rather than using the recently added
--initial-branch
option, we now just renamed the initial branch usinggit branch -m main
.Fixes #1168