Skip to content

Conversation

@efalcao
Copy link
Contributor

@efalcao efalcao commented Sep 14, 2025

Implements WVPC-42.

Add VPC Services bindings
"vpc_services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]

Approval: CR-1304537


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a v3 feature

@efalcao efalcao requested a review from a team as a code owner September 14, 2025 18:37
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2025

🦋 Changeset detected

Latest commit: 1d660a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Minor
wrangler Minor
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a Miniflare plugin to support Mixed Mode

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 15, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10647

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10647

miniflare

npm i https://pkg.pr.new/miniflare@10647

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10647

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10647

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10647

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10647

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10647

wrangler

npm i https://pkg.pr.new/wrangler@10647

commit: 1d660a2

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 17, 2025
Copy link
Contributor

@xortive xortive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@penalosa
Copy link
Contributor

For posterity, let's follow up with E2E tests here as soon as we can

@efalcao
Copy link
Contributor Author

efalcao commented Sep 19, 2025

because this feature is gated to internal emails until next week, e2e testing only works with a User token (which has email claims). CI is set up with an Account token and thus the e2e test for VPC fails. I have attached screenshots of a passing test below and have set a reminder to enable the test next week once it can work with Account tokens

Screenshot 2025-09-19 at 18 18 21 Screenshot 2025-09-19 at 18 19 00

@petebacondarwin petebacondarwin force-pushed the efalcao/vpc-services-binding branch from b0d3fe5 to 64b7da2 Compare September 22, 2025 11:12
@xortive
Copy link
Contributor

xortive commented Sep 22, 2025

Don't have approval perms on workers-sdk, but this looks good from VPC side

@dario-piotrowicz dario-piotrowicz force-pushed the efalcao/vpc-services-binding branch 2 times, most recently from bb758ea to dd9a4e7 Compare September 22, 2025 21:39
@petebacondarwin petebacondarwin force-pushed the efalcao/vpc-services-binding branch from dd9a4e7 to 1d660a2 Compare September 23, 2025 05:44
@petebacondarwin petebacondarwin merged commit 555a6da into main Sep 23, 2025
68 of 78 checks passed
@petebacondarwin petebacondarwin deleted the efalcao/vpc-services-binding branch September 23, 2025 12:54
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants