-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add VPC Services bindings #10647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VPC Services bindings #10647
Conversation
🦋 Changeset detectedLatest commit: 1d660a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a Miniflare plugin to support Mixed Mode
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
xortive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
For posterity, let's follow up with E2E tests here as soon as we can |
b0d3fe5 to
64b7da2
Compare
|
Don't have approval perms on workers-sdk, but this looks good from VPC side |
bb758ea to
dd9a4e7
Compare
`"vpc_services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]`
- removed connectivity from the name - made `type` option required - default ports for http/https - removed tcp service type - made resolver-ips optional
dd9a4e7 to
1d660a2
Compare


Implements WVPC-42.
Add VPC Services bindings
"vpc_services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]Approval: CR-1304537