fix: pages "command" can consist of multiple words #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b3d0878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2347996537/npm-package-wrangler-1057You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1057/npm-package-wrangler-1057Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2347996537/npm-package-wrangler-1057 dev path/to/script.js |
|
Not sure if I can come up with a reasonable test that is not overkill for this small fix... |
On Windows, the following command `wrangler pages dev -- foo bar` would error saying that `bar` was not a known argument. This is because `foo` and `bar` are passed to Yargs as separate arguments. A workaround is to put the command in quotes: `wrangler pages dev -- "foo bar"`. But this fix makes the `command` argument variadic, which also solves the problem. Fixes [cloudflare#965](cloudflare#965)
petebacondarwin
force-pushed
the
fix-pages-command
branch
from
2f1aaef to
b3d0878
Compare
threepointone
approved these changes
May 18, 2022
GregBrimble
approved these changes
May 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the following command
wrangler pages dev -- foo barwould errorsaying that
barwas not a known argument. This is becausefooandbararepassed to Yargs as separate arguments.
A workaround is to put the command in quotes:
wrangler pages dev -- "foo bar".But this fix makes the
commandargument variadic, which also solves the problem.Fixes #965