Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Aug 5, 2025

V3 backport of #10157

…10157)

Fixes #10055 by implementing proper validation in validateWorkflowBinding
function to match production behavior.

- Implemented validateWorkflowBinding function with 64-character name limit
- Added comprehensive tests covering valid/invalid names and boundary cases
- Added validation for required fields (binding, name, class_name)
- Added validation for optional fields (script_name, experimental_remote)
- Created changeset for the feature

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: [email protected] <[email protected]>
@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Aug 5, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner August 5, 2025 10:23
@petebacondarwin petebacondarwin requested a review from a team August 5, 2025 10:23
@petebacondarwin petebacondarwin requested a review from a team as a code owner August 5, 2025 10:23
@petebacondarwin petebacondarwin requested a review from a team August 5, 2025 10:23
@petebacondarwin petebacondarwin requested review from a team as code owners August 5, 2025 10:23
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2025

🦋 Changeset detected

Latest commit: af0b3a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin changed the base branch from main to v3-maintenance August 5, 2025 10:24
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 5, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 5, 2025
@lrapoport-cf lrapoport-cf added the v3-backport The PR is a v3 backport targetting the v3-maintenance branch label Aug 5, 2025
@petebacondarwin petebacondarwin merged commit 989e17e into v3-maintenance Aug 5, 2025
16 checks passed
@petebacondarwin petebacondarwin deleted the v3-backport-10157 branch August 5, 2025 19:25
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format v3-backport The PR is a v3 backport targetting the v3-maintenance branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants