Implement node:fs sync APIs #4138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why didn't you push this on top of #3796? I think we should keep all implementation in a single branch as discussed, before merging. |
anonrig
reviewed
May 12, 2025
| // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unsafe-member-access | ||
| !(globalThis as any).Cloudflare.compatibilityFlags['enable_node_file_system'] | ||
| ) { | ||
| throw new Error('The experimental node:fs implementation is not enabled'); |
Member
There was a problem hiding this comment.
Even though this is behind an experimental flag, we're now throwing a different error message, then we do in the current state. The correct way to do this is through module loader, and just act like "node:fs" doesn't exist (which is the prior behavior to this PR)
Collaborator
Author
|
Will merge these changes into the other PR. That said, there's no reason not to merge into main incrementally under the experimental compat flag so will still likely seek to do the implementation incrementally over a series of individual PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet a full implementation but incrementally getting there. This adds impls for most of the fs sync APIs with a compat flag to enable. Wranglers polyfill overrides are still necessary until these are considered fully complete, tested, and optimized. It should be safe to land these as is, even if still incomplete and not fully tested as an experimental compat flag is required to enable them. I'm going to try to work on these over several PRs in order to keep the overall size of each PR down.