add node:fs and node:fs/promises stub methods #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Mar 25, 2025
vicb
reviewed
Mar 26, 2025
vicb
reviewed
Mar 26, 2025
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
2 times, most recently
from
cace91d to
719b4eb
Compare
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
from
719b4eb to
199e223
Compare
|
The generated output of |
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
3 times, most recently
from
4f61aac to
f0f809b
Compare
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
2 times, most recently
from
183179e to
02dc23f
Compare
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
from
02dc23f to
7e62dfd
Compare
jasnell
previously approved these changes
Apr 17, 2025
anonrig
force-pushed
the
yagiz/add-fs-stub
branch
from
7e62dfd to
c25e24a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
yagiz/add-fs-stub
branch
from
9f45465 to
4029d56
Compare
Collaborator
|
PR updated with a range of APIs implemented. More to come. |
jasnell
force-pushed
the
yagiz/add-fs-stub
branch
8 times, most recently
from
82c9853 to
68ab24b
Compare
anonrig
commented
May 28, 2025
guybedford
approved these changes
May 29, 2025
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Made an initial pass. Great start! The bigger comments about path encoding and errors can certainly be follow-ons, but I also think it's important to get these right early too.
jasnell
force-pushed
the
yagiz/add-fs-stub
branch
from
2ac6d2a to
64b7eab
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
There is still a ton of work to do around this but I'd like to get this bit in then keep iterating in another PR. |
jasnell
force-pushed
the
yagiz/add-fs-stub
branch
from
64b7eab to
7c13182
Compare
jasnell
force-pushed
the
yagiz/add-fs-stub
branch
from
7c13182 to
9a95c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.