-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix node:timers abort callback reset #3380
Conversation
Can you add tests? |
Agreed, see #3363 Note: I just updated my comments, you do need the |
790032a
to
529a313
Compare
Added. This also closes #3363 |
529a313
to
c90fb66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding test 🎉
There seems to be one legit test failure |
c90fb66
to
3f0ffa1
Compare
@anonrig IMO it's better to avoid force pushes after reviews so that it's easier to see what has changed |
There was a git conflict. |
3f0ffa1
to
bf740cf
Compare
I reverted one of the recommendations since it broke ASAN. Here's the correct test (as same as Node.js) that didn't cause ASAN errors: {
const ac = new AbortController();
const signal = ac.signal;
const { promise, resolve } = Promise.withResolvers();
rejects(timersPromises.setImmediate(10, { signal }), /AbortError/).then(
resolve
);
ac.abort();
await promise;
} |
Fixes #3364
Fixes #3363