fix node:timers abort callback reset

Author: anonrig

src/node/internal/internal_timers_promises.ts

@@ -34,6 +34,8 @@ import {
 
 const kScheduler = Symbol.for('kScheduler');
 
+type OnCancelCallback = (() => void) | undefined;
+
 export async function setTimeout<T = void>(
   delay: number | undefined,
   value?: T,
@@ -62,16 +64,23 @@ export async function setTimeout<T = void>(
   }
 
   const { promise, resolve, reject } = Promise.withResolvers<T>();
+  let onCancel: OnCancelCallback;
 
   const timer = timers.setTimeout(() => {
     resolve(value as T);
+    if (onCancel) {
+      signal?.removeEventListener('abort', onCancel);
+    }
   }, delay ?? 0);
 
   if (signal) {
-    function onCancel(): void {
+    onCancel = (): void => {
       timers.clearTimeout(timer);
-      reject(new AbortError(undefined, { cause: signal?.reason }));
-    }
+      if (onCancel) {
+        signal.removeEventListener('abort', onCancel);
+      }
+      reject(new AbortError(undefined, { cause: signal.reason }));
+    };
     signal.addEventListener('abort', onCancel);
   }
 
@@ -101,17 +110,23 @@ export async function setImmediate<T>(
   }
 
   const { promise, resolve, reject } = Promise.withResolvers<T>();
+  let onCancel: OnCancelCallback;
 
   const timer = globalThis.setImmediate(() => {
     resolve(value as T);
+    if (onCancel) {
+      signal?.removeEventListener('abort', onCancel);
+    }
   });
 
   if (signal) {
-    function onCancel(): void {
+    onCancel = (): void => {
       globalThis.clearImmediate(timer);
-      signal?.removeEventListener('abort', onCancel);
-      reject(new AbortError(undefined, { cause: signal?.reason }));
-    }
+      if (onCancel) {
+        signal.removeEventListener('abort', onCancel);
+      }
+      reject(new AbortError(undefined, { cause: signal.reason }));
+    };
     signal.addEventListener('abort', onCancel);
   }
 
@@ -144,7 +159,7 @@ export async function* setInterval<T = void>(
     throw new AbortError(undefined, { cause: signal.reason });
   }
 
-  let onCancel: (() => void) | undefined;
+  let onCancel: OnCancelCallback;
   let interval: timers.Timeout;
   try {
     let notYielded = 0;
@@ -164,8 +179,9 @@ export async function* setInterval<T = void>(
     if (signal) {
       onCancel = (): void => {
         timers.clearInterval(interval);
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        signal.removeEventListener('abort', onCancel!);
+        if (onCancel) {
+          signal.removeEventListener('abort', onCancel);
+        }
         callback?.(
           Promise.reject(new AbortError(undefined, { cause: signal.reason }))
         );