[build] Do not have //src/workerd/io depend on src/cloudflare, src/node #3350
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated output of |
fhanau
force-pushed
the
felix/workerd-io-move
branch
from
c7826d2 to
73bfda9
Compare
This was making io depend on the gen-compile-cache binary, which delayed building source files in io and creating a bottleneck. Drive-by: Fix LLVM 20 operator warnings
fhanau
force-pushed
the
felix/workerd-io-move
branch
from
73bfda9 to
b324f9c
Compare
mar-cf
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was making io depend on the
gen-compile-cachebinary, which created a bottleneck and delayed building source files in io and its dependents.Drive-by: Fix LLVM 20 operator warnings
I have confirmed that downstream CI passes with this change.