Skip to content

Commit c7826d2

Browse files
committed
[build] Do not have //src/workerd/io depend on src/cloudflare, src/node
This was making io depend on the gen-compile-cache binary, which delayed building source files in io and creating a bottleneck. Drive-by: Fix LLVM 20 operator warnings
1 parent 5377f9f commit c7826d2

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

src/workerd/api/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ wd_cc_library(
9595
":memory-cache",
9696
":pyodide",
9797
":r2",
98+
"//src/cloudflare",
99+
"//src/node",
98100
"//src/pyodide",
99101
"//src/pyodide:pyodide_extra_capnp",
100102
"//src/workerd/api/node",

src/workerd/io/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ wd_cc_library(
106106
":supported-compatibility-date_capnp",
107107
":trace",
108108
":worker-interface",
109-
"//src/cloudflare",
110-
"//src/node",
111109
"//src/workerd/api:analytics-engine_capnp",
112110
"//src/workerd/api:data-url",
113111
"//src/workerd/api:deferred-proxy",

src/workerd/jsg/url.c++

+1-1
Original file line numberDiff line numberDiff line change
@@ -2301,6 +2301,6 @@ UrlPattern::UrlPattern(kj::Array<Component> components, bool ignoreCase)
23012301

23022302
} // namespace workerd::jsg
23032303

2304-
const workerd::jsg::Url operator"" _url(const char* str, size_t size) {
2304+
const workerd::jsg::Url operator""_url(const char* str, size_t size) {
23052305
return KJ_ASSERT_NONNULL(workerd::jsg::Url::tryParse(kj::ArrayPtr<const char>(str, size)));
23062306
}

src/workerd/server/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ wd_cc_library(
114114
":alarm-scheduler",
115115
":workerd_capnp",
116116
"//deps/rust:runtime",
117+
"//src/cloudflare",
118+
"//src/node",
117119
"//src/workerd/api:html-rewriter",
118120
"//src/workerd/api:hyperdrive",
119121
"//src/workerd/api:memory-cache",

src/workerd/server/server-test.c++

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ kj::Own<config::Config::Reader> parseConfig(kj::StringPtr text, kj::SourceLocati
5151
// This is intended to allow multi-line raw text to be specified conveniently using C++11
5252
// `R"(blah)"` literal syntax, without the need to mess up indentation relative to the
5353
// surrounding code.
54-
kj::String operator"" _blockquote(const char* str, size_t n) {
54+
kj::String operator""_blockquote(const char* str, size_t n) {
5555
kj::StringPtr text(str, n);
5656

5757
// Ignore a leading newline so that `R"(` can be placed on the line before the initial indent.

0 commit comments

Comments
 (0)