Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-discover new WPT as they are added #3329

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

npaun
Copy link
Member

@npaun npaun commented Jan 13, 2025

WPT regularly adds new tests. To make sure we don't miss any, we automatically generate a test case for each WPT test file discovered within a group.

The manually written test files now contain only a default export containing config for test cases. One new TestRunnerOption was added skipAllTests: true will avoid processing a file if we know there are no test cases we are able to run in that file.

@npaun npaun requested review from jasnell and anonrig January 13, 2025 18:23
@npaun npaun requested review from a team as code owners January 13, 2025 18:23
@npaun npaun force-pushed the npaun/wpt-auto-discovery branch from 0d8f380 to c65f4aa Compare January 13, 2025 18:28
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem we should address in the future is, in node.js, we update wpt by module, meaning, you can update URL tests but not URLPattern. Right now, we have a single dependency, and whenever we update it to latest it will always update everything.

src/workerd/api/wpt/url-test.js Outdated Show resolved Hide resolved
@npaun
Copy link
Member Author

npaun commented Jan 13, 2025

I think we could split the dependency but it might make a mess in deps.jsonc if we eventually enable lots of wpt modules.

@anonrig
Copy link
Member

anonrig commented Jan 13, 2025

I think we could split the dependency but it might make a mess in deps.jsonc if we eventually enable lots of wpt modules.

We can do something similar to Node.js and just clone/copy the necessary directories in the workerd repository.

@npaun npaun force-pushed the npaun/wpt-auto-discovery branch from c65f4aa to f727147 Compare January 13, 2025 22:46
@npaun npaun requested a review from anonrig January 13, 2025 22:46
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review more tomorrow:

build/wpt_test.bzl Show resolved Hide resolved
@npaun npaun force-pushed the npaun/wpt-auto-discovery branch from f727147 to 8f2ff3b Compare January 14, 2025 18:43
@npaun npaun requested a review from anonrig January 14, 2025 18:43
build/wpt_test.bzl Outdated Show resolved Hide resolved
build/wpt_test.bzl Show resolved Hide resolved
src/workerd/api/wpt/BUILD.bazel Outdated Show resolved Hide resolved
src/workerd/api/wpt/url-test.ts Show resolved Hide resolved
@npaun npaun force-pushed the npaun/wpt-auto-discovery branch from 8f2ff3b to b26c692 Compare January 14, 2025 22:38
@npaun npaun force-pushed the npaun/wpt-auto-discovery branch from b26c692 to 433d1f6 Compare January 14, 2025 22:49
@npaun npaun requested a review from anonrig January 14, 2025 22:57
@anonrig anonrig merged commit a81daea into main Jan 15, 2025
15 checks passed
@anonrig anonrig deleted the npaun/wpt-auto-discovery branch January 15, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants