-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-discover new WPT as they are added #3329
Conversation
0d8f380
to
c65f4aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem we should address in the future is, in node.js, we update wpt by module, meaning, you can update URL tests but not URLPattern. Right now, we have a single dependency, and whenever we update it to latest it will always update everything.
I think we could split the dependency but it might make a mess in |
We can do something similar to Node.js and just clone/copy the necessary directories in the workerd repository. |
c65f4aa
to
f727147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review more tomorrow:
f727147
to
8f2ff3b
Compare
8f2ff3b
to
b26c692
Compare
b26c692
to
433d1f6
Compare
WPT regularly adds new tests. To make sure we don't miss any, we automatically generate a test case for each WPT test file discovered within a group.
The manually written test files now contain only a default export containing config for test cases. One new TestRunnerOption was added
skipAllTests: true
will avoid processing a file if we know there are no test cases we are able to run in that file.