Skip to content

Revert "Revert "Disable slow tests by default"" #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2024
Merged

Revert "Revert "Disable slow tests by default"" #2208

merged 3 commits into from
Jun 4, 2024

Conversation

garrettgu10
Copy link
Contributor

@garrettgu10 garrettgu10 commented Jun 3, 2024 •
edited
Loading

Reverts #2207

@garrettgu10 garrettgu10 force-pushed the revert-2207-revert-2205-ggu/disable-slow-tests-by-default branch from ec23efd to 391df37 Compare June 3, 2024 18:21
@garrettgu10 garrettgu10 marked this pull request as ready for review June 3, 2024 21:09
@garrettgu10 garrettgu10 requested review from a team as code owners June 3, 2024 21:09
@garrettgu10
Copy link
Contributor Author

garrettgu10 commented Jun 3, 2024 •
edited
Loading

This works upstream, safe to merge (well, along with the upstream PR)

@fhanau
Copy link
Contributor

fhanau commented Jun 3, 2024 •
edited
Loading

Neither of these files should have any effect on upstream (it has its own bazelrc and CI setup), so yeah this should be plenty safe.

@garrettgu10
Copy link
Contributor Author

Hold on, i think this conflicts with another change that just merged, needs a rebase

@garrettgu10 garrettgu10 force-pushed the revert-2207-revert-2205-ggu/disable-slow-tests-by-default branch from a3eea34 to 2739d60 Compare June 4, 2024 14:38
@garrettgu10 garrettgu10 merged commit f734cf4 into main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@hoodmane hoodmane hoodmane approved these changes

@fhanau fhanau fhanau approved these changes

@mikea mikea Awaiting requested review from mikea mikea is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettgu10 @fhanau @jasnell @hoodmane