Skip to content

Disable slow tests by default #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2024
Merged

Disable slow tests by default #2205

merged 1 commit into from
Jun 1, 2024

Conversation

garrettgu10
Copy link
Contributor

Test plan:

bazel test /src/...

Observe that Python import tests are not run.

Furthermore, Python import tests should be run in:

  1. Linux nondebug on workerd CI
  2. Linux debug on Edgeworker CI

@garrettgu10 garrettgu10 requested review from a team as code owners May 31, 2024 19:25
hoodmane
hoodmane approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasnell jasnell merged commit 10fcf8f into main Jun 1, 2024
10 checks passed
@jasnell jasnell deleted the ggu/disable-slow-tests-by-default branch June 1, 2024 01:33
garrettgu10 added a commit that referenced this pull request Jun 3, 2024
@garrettgu10
Revert "Disable slow tests by default (#2205)"
c753f0e 
This reverts commit 10fcf8f.
@garrettgu10 garrettgu10 mentioned this pull request Jun 3, 2024
Merged
garrettgu10 added a commit that referenced this pull request Jun 3, 2024
@garrettgu10
Revert "Disable slow tests by default (#2205)" (#2207)
96243f3 
This reverts commit 10fcf8f.
garrettgu10 added a commit that referenced this pull request Jun 3, 2024
@garrettgu10
Revert "Revert "Disable slow tests by default (#2205)" (#2207)"
6096fa5 
This reverts commit 96243f3.
garrettgu10 added a commit that referenced this pull request Jun 4, 2024
@garrettgu10
Revert "Revert "Disable slow tests by default"" (#2208)
f734cf4 
* Revert "Revert "Disable slow tests by default (#2205)" (#2207)"

This reverts commit 96243f3.

* remove enable-slow-tests config value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@hoodmane hoodmane hoodmane approved these changes

@harrishancock harrishancock Awaiting requested review from harrishancock harrishancock is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettgu10 @jasnell @hoodmane