Skip to content

feat(zone): add data source migration support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(zone): add data source migration support #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration/v4_to_v5/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import (
_ "github.com/cloudflare/tf-migrate/internal/resources/zero_trust_dlp_custom_profile"
_ "github.com/cloudflare/tf-migrate/internal/resources/zero_trust_gateway_policy"
_ "github.com/cloudflare/tf-migrate/internal/resources/zero_trust_list"
_ "github.com/cloudflare/tf-migrate/internal/resources/zone_data_source"
_ "github.com/cloudflare/tf-migrate/internal/resources/zone_dnssec"
)

// TestMain explicitly registers migrations for this version path
Expand Down
177 changes: 177 additions & 0 deletions integration/v4_to_v5/testdata/zone_data_source/expected/terraform.tfstate
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
{
"lineage": "test-zone-datasource-lineage",
"outputs": {},
"resources": [
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "example.com",
"name_servers": [
"ns1.cloudflare.com",
"ns2.cloudflare.com"
],
"paused": false,
"plan": "free",
"status": "active",
"vanity_name_servers": [],
"zone_id": "abc123def456"
},
"schema_version": 0
}
],
"mode": "data",
"name": "by_id",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "test.example.com",
"name_servers": [
"ns3.cloudflare.com",
"ns4.cloudflare.com"
],
"paused": false,
"plan": "pro",
"status": "active",
"vanity_name_servers": [],
"zone_id": "xyz789uvw012"
},
"schema_version": 0
}
],
"mode": "data",
"name": "by_id_with_account",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "example.com",
"name_servers": [
"ns1.cloudflare.com",
"ns2.cloudflare.com"
],
"paused": false,
"plan": "free",
"status": "active",
"vanity_name_servers": null,
"zone_id": "name123xyz456"
},
"schema_version": 0
}
],
"mode": "data",
"name": "by_name",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "test.example.com",
"name_servers": [],
"paused": true,
"plan": "business",
"status": "pending",
"vanity_name_servers": [
"ns5.example.com",
"ns6.example.com"
],
"zone_id": "namewithacct789"
},
"schema_version": 0
}
],
"mode": "data",
"name": "by_name_with_account",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "account-zone.com",
"name_servers": [
"ns7.cloudflare.com",
"ns8.cloudflare.com"
],
"paused": false,
"plan": "enterprise",
"status": "active",
"vanity_name_servers": [],
"zone_id": "accountonly999"
},
"schema_version": 0
}
],
"mode": "data",
"name": "by_account",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "variable-zone.com",
"name_servers": [
"ns9.cloudflare.com",
"ns10.cloudflare.com"
],
"paused": false,
"plan": null,
"status": "active",
"vanity_name_servers": null,
"zone_id": "variable123abc"
},
"schema_version": 0
}
],
"mode": "data",
"name": "with_variable",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
},
{
"instances": [
{
"attributes": {
"account_id": "f037e56e89293a057740de681ac9abbe",
"name": "multi-var-zone.com",
"name_servers": [
"ns11.cloudflare.com",
"ns12.cloudflare.com"
],
"paused": false,
"plan": "free",
"status": "moved",
"vanity_name_servers": [],
"zone_id": "variables456def"
},
"schema_version": 0
}
],
"mode": "data",
"name": "with_variables",
"provider": "provider[\"registry.terraform.io/cloudflare/cloudflare\"]",
"type": "cloudflare_zone"
}
],
"serial": 1,
"terraform_version": "1.5.0",
"version": 4
}
52 changes: 52 additions & 0 deletions integration/v4_to_v5/testdata/zone_data_source/expected/zone.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Test Case 1: Zone lookup by zone_id only
data "cloudflare_zone" "by_id" {
zone_id = "abc123def456"
}

# Test Case 2: Zone lookup by zone_id with account_id (should remove account_id)
data "cloudflare_zone" "by_id_with_account" {
zone_id = "xyz789uvw012"
}

# Test Case 3: Zone lookup by name only
data "cloudflare_zone" "by_name" {
filter = {
name = "example.com"
}
}

# Test Case 4: Zone lookup by name with account_id
data "cloudflare_zone" "by_name_with_account" {
filter = {
name = "test.example.com"
account = {
id = "f037e56e89293a057740de681ac9abbe"
}
}
}

# Test Case 5: Zone lookup by account_id only
data "cloudflare_zone" "by_account" {
filter = {
account = {
id = "f037e56e89293a057740de681ac9abbe"
}
}
}

# Test Case 6: Zone lookup by name with variable
data "cloudflare_zone" "with_variable" {
filter = {
name = var.zone_name
}
}

# Test Case 7: Zone lookup by name with account_id variable
data "cloudflare_zone" "with_variables" {
filter = {
name = var.zone_name
account = {
id = var.account_id
}
}
}
Loading
Loading