feat(zone): add data source migration support #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgirouard
force-pushed
the
mgirouard/APIOPS-11571-migrate-zone-datasource
branch
from
489393f to
b4ae8d8
Compare
mgirouard
changed the title
mgirouard
requested review from
SirCortly,
musa-cf,
rotem-cloud,
ssicard,
tamas-jozsa and
vaishakdinesh
ssicard
approved these changes
Nov 12, 2025
mgirouard
force-pushed
the
mgirouard/APIOPS-11571-migrate-zone-datasource
branch
from
b4ae8d8 to
e87ef19
Compare
vaishakdinesh
approved these changes
Nov 14, 2025
tamas-jozsa
reviewed
Nov 14, 2025
Collaborator
There was a problem hiding this comment.
E2E is failing on this configuration. Run subtask 08 to regen a correct and more comprehensive integration / e2e test data. Check how integration testdata for dns_record looks like.
tamas-jozsa
reviewed
Nov 14, 2025
Collaborator
There was a problem hiding this comment.
maybe you need to rebase on main, but there is a missing unimplemented method
func (m *V4ToV5Migrator) GetResourceRename() (string, string) {
that is responsible for registering resource renames for global cross references.
Collaborator
Author
There was a problem hiding this comment.
Got it, I'll add the implementation.
Lets log an issue for follow up to rename that method since its not correct that only resources can be renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.