fix(ai-chat): preserve server-generated messages when client appends new messages - #1038
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 03fe9c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
_deleteStaleRowsreconciliation inpersistMessages(added in #1014 for regenerate support) was too aggressive. When a client sent a chat request with new messages that didn't include the full server history, it deleted server-generated assistant messages the client hadn't seen yet.This caused the "multiple messages accumulate in conversation" e2e test to fail: the second request's
persistMessagescall deleted the first assistant message because it wasn't in the incoming message set.Fix
Gate stale row deletion on whether the incoming messages are a subset of the server state. This distinguishes:
Changes
packages/ai-chat/src/index.ts: AddisSubsetOfServerguard before stale row deletionpackages/ai-chat/src/tests/regenerate-message.test.ts: Add regression testTesting