Skip to content

ci(vscode): serialize marketplace publish with retries - #540

Merged
16bit-ykiko merged 3 commits into
mainfrom
ci/serial-marketplace-publish
Jul 22, 2026
Merged

16bit-ykiko merged 3 commits into
mainfrom
ci/serial-marketplace-publish

Conversation

@16bit-ykiko

Copy link
Copy Markdown
Member

The nightly for v0.1.2026072205 needed four attempts because the Marketplace intermittently returns internal errors (TF400898) when six platform publishes for one extension land concurrently — each rerun cleared a few more targets (3 → 2 → 1 → 0 failures). Parallel release-asset uploads from six jobs also race on the same release.

  • The six-target packaging matrix stays parallel and now only produces vsix workflow artifacts.
  • A new serial publish-release job collects the six vsix files, uploads them to the GitHub release in one gh release upload --clobber call, then publishes them to the Marketplace one at a time with 3 attempts per vsix (30s backoff).
  • Reruns are idempotent: --clobber re-uploads cleanly and vsce --skip-duplicate treats versions an earlier attempt already published as success.
  • Deliberate semantic change: publishing is now all-or-nothing behind the full packaging matrix (needs: publish-vscode). Previously a failed target still let the other five publish, which is exactly the partial state that made reruns awkward; a failed leg now means rerun the failed jobs and publish once, atomically.
  • The release runbook documents the recovery path: transient Marketplace failures are fixed by rerunning the publish-release job, never by a new tag.

Verified with actionlint; per-path behavior (nightly dispatch, stable tag push, PR check, instant builds) audited against all four callers.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 44a880d5-e70d-421d-98e9-5b0b3fa2ef92

📥 Commits

Reviewing files that changed from the base of the PR and between b04263f and 8bcf44a.

📒 Files selected for processing (1)
  • .github/workflows/publish-vscode.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/publish-vscode.yml

📝 Walkthrough

Walkthrough

VSIX packaging remains parallelized, while release upload and Marketplace publishing now run in a separate serial job with per-file retries and duplicate handling. Release documentation describes rerunning failed work safely.

Changes

VSIX release flow

Layer / File(s) Summary
Release artifact collection and publishing
.github/workflows/publish-vscode.yml, .github/workflows/publish-clice.yml
The workflow collects packaged VSIX artifacts, resolves the release tag, uploads them to the GitHub Release, and publishes each file sequentially with up to three attempts and --skip-duplicate.
Release recovery documentation
.claude/commands/release.md
Release guidance documents serialized Marketplace publishing and rerunning failed work with clobbering and duplicate skipping.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • clice-io/clice#524: Establishes the release_tag-based release automation extended by this change.
  • clice-io/clice#525: Also changes GitHub Release upload and Marketplace publishing order in the VSIX workflow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: serializing VS Code Marketplace publishing with retries.
Description check ✅ Passed The description is clearly related to the workflow and release-process changes in this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/serial-marketplace-publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/publish-vscode.yml:
- Around line 179-183: Update the release upload step to define the resolved
release tag as an environment variable named RELEASE_TAG, then pass
"$RELEASE_TAG" to gh release upload instead of interpolating inputs.release_tag
or github.ref_name in the shell command. Preserve the existing repository,
clobber, and VSIX arguments.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ff1b2185-107f-498c-a4c2-e5cd2d6e0bca

📥 Commits

Reviewing files that changed from the base of the PR and between bb6d11d and 3b72d46.

📒 Files selected for processing (2)
  • .claude/commands/release.md
  • .github/workflows/publish-vscode.yml

Comment thread .github/workflows/publish-vscode.yml
@16bit-ykiko
16bit-ykiko merged commit 08a586c into main Jul 22, 2026
16 checks passed
@16bit-ykiko
16bit-ykiko deleted the ci/serial-marketplace-publish branch July 22, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant