Skip to content

fix(release): upload vsix to release before marketplace publish - #525

Merged
16bit-ykiko merged 1 commit into
mainfrom
fix/vsix-upload-order
Jul 18, 2026
Merged

16bit-ykiko merged 1 commit into
mainfrom
fix/vsix-upload-order

Conversation

@16bit-ykiko

@16bit-ykiko 16bit-ykiko commented Jul 18, 2026 •

Copy link
Copy Markdown
Member

The first nightly (v0.1.26071809) uploaded all 12 server assets but lost its 6 vsix release assets: the Marketplace publish step failed on a missing VSCE_PAT and blocked the subsequent release-asset upload. Reordering makes the GitHub release complete regardless of Marketplace credential state; the Marketplace step still fails visibly when the PAT is absent or invalid.

Summary by CodeRabbit

  • Chores
    • Updated the release workflow so the VS Code extension is uploaded to the release before being published to the marketplace.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2541c8b7-4f08-457d-a286-732c8b8a38de

📥 Commits

Reviewing files that changed from the base of the PR and between 935cc24 and b22567b.

📒 Files selected for processing (1)
  • .github/workflows/publish-vscode.yml

📝 Walkthrough

Walkthrough

The VS Code publishing workflow now uploads generated VSIX files to the release before publishing them to the Marketplace. Marketplace conditions, authentication, prerelease handling, and package paths remain unchanged.

Changes

VS Code release publishing

Layer / File(s) Summary
Publish after release upload
.github/workflows/publish-vscode.yml
The Marketplace publication step now runs after the VSIX is uploaded to the release, with its existing configuration preserved.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: uploading the VSIX to the release before publishing to the Marketplace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vsix-upload-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@16bit-ykiko
16bit-ykiko merged commit cc5208d into main Jul 18, 2026
28 checks passed
@16bit-ykiko
16bit-ykiko deleted the fix/vsix-upload-order branch August 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant