Skip to content

Conversation

@SarahSoutoul
Copy link
Contributor

@SarahSoutoul SarahSoutoul commented Dec 10, 2025

Description

This needs to be merged first: clerk/clerk-docs#2868

The javascript repo now has a release/core-2 branch representing our "old" main, and the main branch is now representing core-3 stuff. This change is messing up our Typedoc workflow, as it created a generated Typedoc PR containing core-3 changes to be merged into main, and that's not what we want.

So, this PR So adds a dedicated workflow for Typedoc for core 2:

so now

  1. clerk/javascript @ release/core-2 will open prs to clerk/clerk-docs @ main
  2. clerk/javascript @ main will open prs to clerk/clerk-docs @ core-3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added API key management operations: retrieve, update, and delete individual API keys.
    • Enhanced API key revocation with optional reason parameter.
  • Improvements

    • Updated security messaging for password reset workflows.
    • Expanded Polish language translations for organization and API key interface elements.
  • Chores

    • Updated release workflows and branch configurations.
    • Bumped package versions across backend and framework integrations.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Skipped Skipped Dec 10, 2025 6:50pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

⚠️ No Changeset found

Latest commit: 6bab05b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR refocuses the repository toward the release/core-2 branch by updating build configuration and CI/CD pipelines, extends API key management with new get, update, and delete methods plus an enhanced revoke signature, and releases synchronized version bumps across multiple packages with dependency updates and localization improvements.

Changes

Cohort / File(s) Summary
Configuration & CI/CD Updates
.changeset/config.json, .github/workflows/ci.yml, .github/workflows/release.yml
Updated changeset base branch from origin/main to origin/release/core-2; redirected CI triggers and release workflows to target release/core-2 branch only; added concurrency cancellation and refined checkout behavior (fetch-depth, fetch-tags, filter).
Removed Workflows
.github/workflows/nightly-checks.yml, .github/workflows/preview.retheme.yml, .github/workflows/release-canary.yml
Removed three GitHub Actions workflows: nightly integration tests, Retheme preview deployment, and canary release automation.
API Keys Feature Expansion
packages/backend/src/api/endpoints/APIKeysApi.ts, packages/backend/src/api/__tests__/APIKeysApi.test.ts, integration/testUtils/usersService.ts
Added new API methods get(), update(), and delete() to APIKeysAPI; updated revoke() signature to accept optional reason parameter; introduced UpdateAPIKeyParams type; added comprehensive test coverage.
Integration & Test Updates
integration/tests/machine-auth/api-keys.test.ts, integration/tests/session-tasks-sign-in-reset-password.test.ts
Updated API key revocation calls to pass reason argument; refreshed test assertion messages for password reset flow.
Version Bumps & Changelogs
packages/agent-toolkit/*, packages/astro/*, packages/backend/*, packages/chrome-extension/*, packages/clerk-js/*, packages/expo/*, packages/express/*, packages/fastify/*, packages/nextjs/*, packages/nuxt/*, packages/react-router/*, packages/remix/*, packages/tanstack-react-start/*, packages/testing/*
Incremented package versions (minor or patch) and added changelog entries documenting dependency updates to @clerk/[email protected] and related packages.
Localization Updates
packages/localizations/CHANGELOG.md, packages/localizations/package.json, packages/localizations/src/pl-PL.ts
Version bump to 3.30.1; added concrete Polish translations for organization-related UI elements (create organization, switcher labels, task forms, API keys pages).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

  • Areas requiring extra attention:
    • .github/workflows/release.yml — verify branch references, workflow dispatch targets (typedoc-core-2.yml), and concurrency configuration align with release strategy
    • packages/backend/src/api/endpoints/APIKeysApi.ts — confirm new update() and delete() signatures are correct and revoke() reason parameter flows properly
    • packages/backend/src/api/__tests__/APIKeysApi.test.ts — validate test coverage spans all new endpoints and error conditions
    • packages/localizations/src/pl-PL.ts — review accuracy of Polish translations for organizational context and UI consistency

Possibly related PRs

  • ci(repo): Version packages #6136 — Introduces new backend API keys methods (revoke, update, get, delete) and related signature changes to the APIKeysApi surface.

Suggested labels

types, clerk-js, nextjs, react, remix, backend, fastify, localizations, expo, chrome-extension, express, testing, tanstack, astro, react-router, nuxt, agent-toolkit

Suggested reviewers

  • LauraBeatris
  • wobsoriano
  • jfoshee
  • dstaley

Poem

🐰 A shift to core-2, the workflows now gleam,
New API keys methods fulfill the team's dream—
Get, update, delete with reasons so clear,
Version bumps flowing through packages sincere,
Polish translations complete the affair! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title describes a workflow change related to typedoc for core 2, which aligns with major changes to .github/workflows/release.yml that update the workflow to target release/core-2 branch and reference typedoc-core-2.yml instead of typedoc.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SarahSoutoul SarahSoutoul marked this pull request as ready for review December 10, 2025 18:33
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7426

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7426

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7426

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7426

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7426

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7426

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7426

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7426

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7426

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7426

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7426

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7426

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7426

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7426

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7426

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7426

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7426

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7426

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7426

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7426

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7426

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7426

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7426

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7426

commit: 6bab05b

@SarahSoutoul SarahSoutoul merged commit f49e8aa into release/core-2 Dec 10, 2025
44 checks passed
@SarahSoutoul SarahSoutoul deleted the ss/fix-typedoc-workflow-core-3 branch December 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants