-
Notifications
You must be signed in to change notification settings - Fork 411
chore(elements): Support next@16 #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8f258cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR updates Next.js peer dependency compatibility in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)
🔇 Additional comments (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/honest-baths-brush.md (1)
5-5: Consider providing more context in the changeset description.The description mentions adding Next.js v16 support but doesn't explain the minimum version bumps on existing ranges (13.5.7, 14.2.25, 15.2.3). Consider clarifying whether these are required for compatibility or just updated constraints.
For example, update the description to:
Update peerDependencies to support NextJs v16 and adjust minimum version constraints for existing ranges to address compatibility issues.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/honest-baths-brush.md(1 hunks)packages/elements/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
packages/elements/package.json (1)
93-93: Verify compatibility testing with Next.js v16 and clarify minimum version constraints.The peer dependency update adds support for Next.js v16 and adjusts minimum versions for existing ranges. The version bumps (14.0.3→14.2.25 and the addition of 15.2.3 constraints) suggest addressing compatibility issues, but the rationale is not documented in the PR description or commit messages.
Before merging, ensure that:
- Next.js v16 compatibility has been verified (particularly with @clerk/elements' Next.js-specific features).
- The minimum version bumps (13.5.7, 14.2.25, 15.2.3) are justified (e.g., bug fixes, API stability) rather than arbitrary constraints.
- Existing consumers on v13.5.4, v14.0.x, or earlier v15 patches receive clear migration guidance if they need to upgrade.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.