Skip to content

chore(clerk-js): Add temporary API keys limit query for pagination compatibility #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wobsoriano merged 3 commits into from
Jul 31, 2025
Merged

chore(clerk-js): Add temporary API keys limit query for pagination compatibility #6451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4acb048
chore(clerk-js): Add temporary API keys limit query for compatibility
wobsoriano Jul 31, 2025
7c5757d
chore: add changeset
wobsoriano Jul 31, 2025
ab8732c
chore: add comment
wobsoriano Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tired-lines-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Added temporary patch for API keys pagination compatibility
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/modules/apiKeys/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ export class APIKeys implements APIKeysNamespace {
path: '/api_keys',
search: {
subject: params?.subject ?? BaseResource.clerk.organization?.id ?? BaseResource.clerk.user?.id ?? '',
// TODO: (rob) Remove when server-side pagination is implemented.
limit: '100',
Copy link
Contributor

@panteliselef panteliselef Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the endpoint have a default low limit ? Like 10, 20, 100 ?

Copy link
Member Author

@wobsoriano wobsoriano Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, default of 10 but some early access users might already have more than that, and the component pagination is currently client-side. Need to do another PR to make sure we do pagination server-side.

},
})
.then(res => {
Expand Down
Loading