-
Notifications
You must be signed in to change notification settings - Fork 419
fix(types,clerk-js): Remove statement_id from the checkout resource
#6437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types,clerk-js): Remove statement_id from the checkout resource
#6437
Conversation
🦋 Changeset detectedLatest commit: 039b987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis change removes the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/wicked-cases-sink.md(1 hunks)packages/clerk-js/src/core/modules/checkout/__tests__/manager.spec.ts(0 hunks)packages/clerk-js/src/core/resources/CommerceCheckout.ts(0 hunks)packages/shared/src/react/hooks/__tests__/useCheckout.type.spec.ts(0 hunks)packages/shared/src/react/hooks/useCheckout.ts(0 hunks)packages/types/src/commerce.ts(0 hunks)packages/types/src/json.ts(0 hunks)
💤 Files with no reviewable changes (6)
- packages/clerk-js/src/core/modules/checkout/tests/manager.spec.ts
- packages/types/src/json.ts
- packages/shared/src/react/hooks/tests/useCheckout.type.spec.ts
- packages/clerk-js/src/core/resources/CommerceCheckout.ts
- packages/shared/src/react/hooks/useCheckout.ts
- packages/types/src/commerce.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/wicked-cases-sink.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
.changeset/wicked-cases-sink.md
Outdated
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| [Billing Beta]: Remove `statement_id` from the checkout resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove square-bracket syntax – it creates a link reference and hides the description.
In Markdown, [Billing Beta]: … is parsed as a link reference definition, so the rendered body will be empty and the changeset description will not appear in release notes.
Replace the brackets with plain text.
-[Billing Beta]: Remove `statement_id` from the checkout resource.
+Billing Beta: Remove `statement_id` from the checkout resource.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| [Billing Beta]: Remove `statement_id` from the checkout resource. | |
| Billing Beta: Remove `statement_id` from the checkout resource. |
🤖 Prompt for AI Agents
In .changeset/wicked-cases-sink.md at line 7, the changeset description uses
square brackets around "Billing Beta" which Markdown interprets as a link
reference, causing the description to be hidden in release notes. Remove the
square brackets and replace "[Billing Beta]" with plain text "Billing Beta" to
ensure the description is visible.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
statement_id from the checkout resource.statement_id from the checkout resource
Co-authored-by: Bryce Kalow <[email protected]>
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Refactor
Tests