Skip to content

Conversation

@panteliselef
Copy link
Contributor

@panteliselef panteliselef commented Jul 30, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor

    • Removed the statement ID field from the checkout resource in the Billing Beta feature.
  • Tests

    • Updated tests to reflect the removal of the statement ID property from checkout-related resources.

@panteliselef panteliselef requested a review from aeliox July 30, 2025 11:04
@panteliselef panteliselef self-assigned this Jul 30, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2025

🦋 Changeset detected

Latest commit: 039b987

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Minor
@clerk/shared Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/vue Patch
@clerk/localizations Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 2:50pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2025

📝 Walkthrough

Walkthrough

This change removes the statement_id property from the checkout resource in the Billing Beta feature. The update spans multiple packages, including @clerk/clerk-js, @clerk/shared, and @clerk/types. Modifications include deleting the statement_id field from interface and class definitions, test utilities, type tests, and the default object construction in the useCheckout hook. No new properties or logic were introduced, and no exported or public entity signatures were otherwise altered except for the removal of statement_id from relevant interfaces and classes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Complexity: Simple. The changes are straightforward removals of a single property across several files, with minor adjustments to related tests and type definitions. No new logic or complex refactoring is introduced.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 820bc06 and 039b987.

📒 Files selected for processing (2)
  • .changeset/wicked-cases-sink.md (1 hunks)
  • packages/clerk-js/src/core/modules/checkout/__tests__/manager.spec.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/clerk-js/src/core/modules/checkout/tests/manager.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/wicked-cases-sink.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c69de58 and 820bc06.

📒 Files selected for processing (7)
  • .changeset/wicked-cases-sink.md (1 hunks)
  • packages/clerk-js/src/core/modules/checkout/__tests__/manager.spec.ts (0 hunks)
  • packages/clerk-js/src/core/resources/CommerceCheckout.ts (0 hunks)
  • packages/shared/src/react/hooks/__tests__/useCheckout.type.spec.ts (0 hunks)
  • packages/shared/src/react/hooks/useCheckout.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (6)
  • packages/clerk-js/src/core/modules/checkout/tests/manager.spec.ts
  • packages/types/src/json.ts
  • packages/shared/src/react/hooks/tests/useCheckout.type.spec.ts
  • packages/clerk-js/src/core/resources/CommerceCheckout.ts
  • packages/shared/src/react/hooks/useCheckout.ts
  • packages/types/src/commerce.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/wicked-cases-sink.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)

'@clerk/types': minor
---

[Billing Beta]: Remove `statement_id` from the checkout resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove square-bracket syntax – it creates a link reference and hides the description.

In Markdown, [Billing Beta]: … is parsed as a link reference definition, so the rendered body will be empty and the changeset description will not appear in release notes.
Replace the brackets with plain text.

-[Billing Beta]: Remove `statement_id` from the checkout resource.
+Billing Beta: Remove `statement_id` from the checkout resource.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[Billing Beta]: Remove `statement_id` from the checkout resource.
Billing Beta: Remove `statement_id` from the checkout resource.
🤖 Prompt for AI Agents
In .changeset/wicked-cases-sink.md at line 7, the changeset description uses
square brackets around "Billing Beta" which Markdown interprets as a link
reference, causing the description to be hidden in release notes. Remove the
square brackets and replace "[Billing Beta]" with plain text "Billing Beta" to
ensure the description is visible.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 30, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6437

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6437

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6437

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6437

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6437

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6437

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6437

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6437

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6437

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6437

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6437

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6437

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6437

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6437

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6437

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6437

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6437

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6437

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6437

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6437

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6437

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6437

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6437

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6437

commit: 039b987

@panteliselef panteliselef changed the title fix(types,clerk-js): Remove statement_id from the checkout resource. fix(types,clerk-js): Remove statement_id from the checkout resource Jul 30, 2025
@panteliselef panteliselef merged commit 3d1d871 into main Jul 30, 2025
38 checks passed
@panteliselef panteliselef deleted the elef/com-1071-drop-statement_id-from-clerk-js branch July 30, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants