fix(clerk-js): Remove cache revalidation hooks from pending session handling #6389

LauraBeatris · 2025-07-24T17:43:48Z

Description

This PR removes onBeforeSetActive and onAfterSetActive from being executed on the pending session handling within setActive

This was leading to multiple issues of SignIn and SignUp getting unmounted, since the server would refetch/refresh components and leave the session with an undefined state, causing withCoreSessionGuard to unmount AIOs.

We didn't have these issues outside of after-auth flows (meaning when pending status doesn't exist and it goes from an empty session to active) since setActive would always execute Next.js router navigation to a page outside of AIOs.

Tradeoffs

Since those cache revalidation hooks aren't executed, it's possible that RSCs and middleware logic that relies on the pending session, doesn't get trigger once the AIO is on the select-organization screen. Examples could be trying to extract the userId with auth({ treatPendingAsSignedOut: false })

We think the tradeoff is worth tho, since atm, there's no clear indication that this would make sense while using AIOs in an after-auth flow.

If the developer wants to rely on the pending session granularly as a signed-in state on server-side logic, they can do so with custom pages by ejecting out of AIOs with <ClerkProvider taskUrls={{ 'select-organization': '/my-server-rendered-page' />

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Bug Fixes
- Resolved issues causing component unmounting in SignIn and SignUp All-In-One flows after authentication.
- Improved session handling to prevent unmounting problems during post-authentication processes.

vercel · 2025-07-24T17:43:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 8:54pm

changeset-bot · 2025-07-24T17:43:52Z

🦋 Changeset detected

Latest commit: 1035bce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-24T17:52:45Z

📝 Walkthrough

Walkthrough

The changes remove cache revalidation hooks from the handling of pending sessions in the '@clerk/clerk-js' package. Specifically, the invocation of the onBeforeSetActive hook within the setActive method of the Clerk class has been reordered. The hook is now called after checking for and handling a pending session, rather than before. Additionally, the call to onAfterSetActive after handling a pending session has been eliminated. No exported or public entity signatures were altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7286a45 and 1035bce.

📒 Files selected for processing (1)

.changeset/full-impalas-wonder.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

.changeset/full-impalas-wonder.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: semgrep-cloud-platform/scan
GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: Build Packages
GitHub Check: semgrep/ci
GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NicolasLopes7

The changes looks straightforward enough 👍

iagodahlem

Couldn't test it yet, having troubles to setup playgrounds, will try it again later and give this one a try too!

Examples could be trying to extract the userId with auth({ treatPendingAsSignedOut: false })

Maybe we should mention that in the docs as well.

LauraBeatris · 2025-07-24T20:37:52Z

Couldn't test it yet, having troubles to setup playgrounds, will try it again later and give this one a try too!

Examples could be trying to extract the userId with auth({ treatPendingAsSignedOut: false })

Maybe we should mention that in the docs as well.

@iagodahlem We already have treatPendingAsSignedOut on auth docs but haven't introduced it on a specific guide with actual use case... I'd say, I'm curious on how developers would use it as well.

My idea is that it'd be mostly used for API routes or server actions. The majority of the B2B app logics will require to treat pending as signed-out to make sure orgs are defined so I can imagine that treatPendingAsSignedOut: false would be quite rare.

pkg-pr-new · 2025-07-24T20:56:52Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6389

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6389

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6389

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6389

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6389

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6389

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6389

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6389

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6389

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6389

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6389

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6389

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6389

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6389

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6389

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6389

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6389

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6389

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6389

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6389

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6389

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6389

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6389

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6389

commit: 1035bce

iagodahlem · 2025-07-25T13:21:42Z

Couldn't test it yet, having troubles to setup playgrounds, will try it again later and give this one a try too!

Examples could be trying to extract the userId with auth({ treatPendingAsSignedOut: false })

Maybe we should mention that in the docs as well.

@iagodahlem We already have treatPendingAsSignedOut on auth docs but haven't introduced it on a specific guide with actual use case... I'd say, I'm curious on how developers would use it as well.

My idea is that it'd be mostly used for API routes or server actions. The majority of the B2B app logics will require to treat pending as signed-out to make sure orgs are defined so I can imagine that treatPendingAsSignedOut: false would be quite rare.

Oh, I think I get it, makes sense to me, thanks for explaining it @LauraBeatris! 🙌

LauraBeatris self-assigned this Jul 24, 2025

clerk-cookie added the clerk-js label Jul 24, 2025

vercel bot deployed to Preview July 24, 2025 17:45 View deployment

LauraBeatris requested a review from a team July 24, 2025 17:50

LauraBeatris marked this pull request as ready for review July 24, 2025 17:50

Remove cache revalidation hooks from pending session handling

684d747

LauraBeatris force-pushed the laura/remove-cache-revalidation-for-tasks-aios branch from 7c17599 to 7286a45 Compare July 24, 2025 17:50

vercel bot deployed to Preview July 24, 2025 17:53 View deployment

LauraBeatris requested a review from brkalow July 24, 2025 18:00

NicolasLopes7 approved these changes Jul 24, 2025

View reviewed changes

iagodahlem approved these changes Jul 24, 2025

View reviewed changes

Add changeset

1035bce

LauraBeatris force-pushed the laura/remove-cache-revalidation-for-tasks-aios branch from 7286a45 to 1035bce Compare July 24, 2025 20:53

vercel bot deployed to Preview July 24, 2025 20:54 View deployment

LauraBeatris enabled auto-merge (squash) July 24, 2025 21:04

LauraBeatris merged commit 6876563 into main Jul 24, 2025
38 checks passed

LauraBeatris deleted the laura/remove-cache-revalidation-for-tasks-aios branch July 24, 2025 21:04

clerk-cookie mentioned this pull request Jul 24, 2025

ci(repo): Version packages #6385

Merged

fix(clerk-js): Remove cache revalidation hooks from pending session handling #6389

fix(clerk-js): Remove cache revalidation hooks from pending session handling #6389

Uh oh!

Conversation

LauraBeatris commented Jul 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

NicolasLopes7 left a comment

Choose a reason for hiding this comment

Uh oh!

iagodahlem left a comment

Choose a reason for hiding this comment

Uh oh!

LauraBeatris commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 24, 2025

Uh oh!

Uh oh!

iagodahlem commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LauraBeatris commented Jul 24, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 24, 2025 •

edited

Loading

changeset-bot bot commented Jul 24, 2025 •

edited

Loading

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

LauraBeatris commented Jul 24, 2025 •

edited

Loading